IsoTpParallelQuery: extend timeout for every frame type #29654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
sshane
added a commit
that referenced
this pull request
Aug 29, 2023
…)" This reverts commit a160f1a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not just consecutive. Does this by adding more checks to IsoTpMessage in panda so we throw an exception on broadcast addrs instead of timing out. A Toyota ECU was also seen taking a long time to respond with a first consecutive frame, so this reduces accidental time outs.
openpilot PR this partially reverts, allowed due to the added panda iso-tp checks: #27762
panda PRs:
commaai/panda#1487
commaai/panda#1610