Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

card: fix memory leak from nested function scoping #33328

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Aug 19, 2024

there probably was a cyclic reference due to the nesting

introduced in #33208

@github-actions github-actions bot added the car vehicle-specific label Aug 19, 2024
@sshane sshane added the bugfix label Aug 19, 2024
@sshane sshane force-pushed the fix-card-memory-leak-asdictref branch from 9f5ee1a to 333a9c5 Compare August 19, 2024 21:14
@sshane sshane merged commit ee9977d into master Aug 19, 2024
19 checks passed
@sshane sshane deleted the fix-card-memory-leak-asdictref branch August 19, 2024 21:27
Edison-CBS pushed a commit to Edison-CBS/openpilot that referenced this pull request Sep 15, 2024
* stash

* no other leaks! pm.send grows memory usage by ~20mb but that's it

* undo

* clean up
old-commit-hash: ee9977d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix car vehicle-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant