Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: print VIN when getting UDS fingerprints from a route #33750

Merged
merged 2 commits into from
Oct 8, 2024
Merged

tools: print VIN when getting UDS fingerprints from a route #33750

merged 2 commits into from
Oct 8, 2024

Conversation

jyoung8607
Copy link
Collaborator

@jyoung8607 jyoung8607 commented Oct 8, 2024 •
edited
Loading

Description

Print the VIN when running selfdrive/debug/fingerprint_from_route.py.

Verification

Needed (and used) this several times in the past couple weeks.

  • VIN is now relevant to fingerprinting for multiple car platforms
  • Sometimes I need the VIN from a route that's marked public but device not shared, so no useradmin
  • Sometimes useradmin can't parse logs: for new car ports, or after big capnp changes, or from forks

@sshane sshane merged commit 8b5df1e into commaai:master Oct 8, 2024
14 checks passed
@jyoung8607 jyoung8607 deleted the fp-tool-update branch October 8, 2024 20:57
cydia2020 pushed a commit to cydia2020/dodgypilot that referenced this pull request Oct 9, 2024
@jyoung8607 @sshane @cydia2020
tools: print VIN when getting UDS fingerprints from a route (commaai#…
5f5ade3 
…33750)

* tools: print VIN when getting UDS fingerprints

* set in case not there

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jyoung8607 @sshane