CometRepay #45
CometRepay #45
Conversation
scott-silver
force-pushed
the
silver/borrow
branch
from
369bceb
to
0aa9ee4
Compare
scott-silver
force-pushed
the
silver/repay
branch
from
3f2fbbd
to
e5127ad
Compare
| IQuarkWallet.QuarkOperation[] memory quarkOperations = | ||
| new IQuarkWallet.QuarkOperation[](chainAccountsList.length); | ||
|
|
||
| bool useQuotecall = false; // TODO: calculate an actual value for useQuoteCall |
There was a problem hiding this comment.
Trying to think what would be a use case for quotecall in repay.
I guess is when user has 10USDC, and comet has -10USDC, 1ETH.
So user trigger repayMax?
There was a problem hiding this comment.
Yeah repay works kind of like transfer in the sense that tokens are leaving the quark wallet. So the conditions for useQuoteCall would be the same I think
| if (Strings.stringEqIgnoreCase(transferActionContext.assetSymbol, paymentTokenSymbol)) { | ||
| paymentTokenCost += transferActionContext.amount; | ||
| if (Strings.stringEqIgnoreCase(nonBridgeAction.actionType, Actions.ACTION_TYPE_BORROW)) { | ||
| continue; |
There was a problem hiding this comment.
Why we don't have to worry about the cost for BORROW and WITHDRAW 🤔 ?
There was a problem hiding this comment.
because borrowing and/or withdrawing an asset increases your balance of that asset, whereas supplying and/or repaying that asset decreases your balance of that asset
| address constant COMET_1 = address(0xc3); | ||
|
|
||
| address constant LINK_1 = address(0xfeed01); |
There was a problem hiding this comment.
iirc XXX_# the # means the chain id.
To prevent future confusion, probably it's better to use the actual addresses for those that are marked with the actual chain Id like 1 as mainnet?
scott-silver
force-pushed
the
silver/repay
branch
from
e5127ad
to
1e5cb1d
Compare
| IQuarkWallet.QuarkOperation[] memory quarkOperations = | ||
| new IQuarkWallet.QuarkOperation[](chainAccountsList.length); | ||
|
|
||
| bool useQuotecall = false; // TODO: calculate an actual value for useQuoteCall |
There was a problem hiding this comment.
Yeah repay works kind of like transfer in the sense that tokens are leaving the quark wallet. So the conditions for useQuoteCall would be the same I think
No description provided.