Support recurring swaps in QuarkBuilder #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevincheng96
force-pushed
the
kevin/recurring-purchase-quark-builder
branch
from
24d4434
to
e94f6ae
Compare
kevincheng96
commented
Aug 22, 2024
Comment on lines
+1216
to
+1244
| return balanceOnChain; | ||
| } | ||
|
|
||
| function getAmountNeededOnChain( | ||
| string memory assetSymbol, | ||
| uint256 amount, | ||
| uint256 chainId, | ||
| PaymentInfo.Payment memory payment | ||
| ) internal pure returns (uint256) { | ||
| // If action is paid for with tokens and the payment token is the transfer token, then add the payment max cost for the target chain to the amount needed | ||
| uint256 amountNeededOnChain = amount; | ||
| if (payment.isToken && Strings.stringEqIgnoreCase(payment.currency, assetSymbol)) { | ||
| amountNeededOnChain += PaymentInfo.findMaxCost(payment, chainId); | ||
| } | ||
|
|
||
| return amountNeededOnChain; | ||
| } | ||
|
|
||
| function needsBridgedFunds( | ||
| string memory assetSymbol, | ||
| uint256 amount, | ||
| uint256 chainId, | ||
| Accounts.ChainAccounts[] memory chainAccountsList, | ||
| PaymentInfo.Payment memory payment | ||
| ) internal pure returns (bool) { | ||
| uint256 balanceOnChain = getBalanceOnChain(assetSymbol, chainId, chainAccountsList, payment); | ||
| uint256 amountNeededOnChain = getAmountNeededOnChain(assetSymbol, amount, chainId, payment); | ||
|
|
||
| return balanceOnChain < amountNeededOnChain; |
There was a problem hiding this comment.
These diffs are just pulling out the logic in needsBridgedFunds into two separate helper functions.
kevincheng96
force-pushed
the
kevin/recurring-purchase-quark-builder
branch
from
e94f6ae
to
dba1bcd
Compare
banky
reviewed
Aug 27, 2024
|
|
||
| // Mainnet | ||
| function knownPriceFeeds_1() internal pure returns (PriceFeed[] memory) { | ||
| PriceFeed[] memory priceFeeds = new PriceFeed[](4); |
There was a problem hiding this comment.
Do we plan to add every price feed for all supported tokens here?
There was a problem hiding this comment.
Yeah, we'll have to hardcode all the price feeds for tokens we care about. 🧇 is working on a crawler that will output a Solidity config file that will replace this file.
kevincheng96
force-pushed
the
kevin/recurring-purchase-quark-builder
branch
from
dba1bcd
to
9d7c5e1
Compare
kevincheng96
force-pushed
the
kevin/recurring-purchase-quark-builder
branch
from
b0d0e0f
to
d073399
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the QuarkBuilder logic to construct Quark Operations for recurring swaps. We introduce a few new libraries that hardcode some addresses:
PriceFeeds.solandUniswapRouter.sol.