Skip to content
This repository has been archived by the owner on Apr 9, 2020. It is now read-only.

Why isn't the newest version of conda-build used? #38

Closed
asmeurer opened this issue Oct 13, 2016 · 9 comments
Closed

Why isn't the newest version of conda-build used? #38

asmeurer opened this issue Oct 13, 2016 · 9 comments

Comments

@asmeurer
Copy link
Member

This is causing issues for the emacs feedstock, because I need a fix that is only in the latest version of conda-build (or at least newer than what this uses).

@asmeurer
Copy link
Member Author

I guess it was because of #27. Has this been fixed upstream yet? Or worked around downstream?

@jakirkham
Copy link
Member

jakirkham commented Oct 14, 2016

Sort of... 🤔 Basically it is fixed in the script here. However, to use the script here feedstocks need to be re-rendered with conda-smithy version 1.3.x (in practice x should be 2 to get other important fixes).

Edit: By fixes to the upload script I mean PR ( #34 ).

@jakirkham
Copy link
Member

The real problem that is a blocker is that cmake doesn't seem to work on conda-build version 2.0.x. Please see issue ( conda-forge/cmake-feedstock#21 ). If we can solve that, we should be in pretty good shape to proceed. If you have time to look into it, we would certainly appreciate the help.

@asmeurer
Copy link
Member Author

Re that issue: I'm out of the loop these days, but I thought that long prefix length was increased.

Regardless, wouldn't it be better to use the newest version by default, and only pin an older version for packages that are broken? This is preventing any fixes/improvements in conda-build from making their way to any conda-forge builds. So long as the conda-build developer(s) are paying attention to conda-forge issues, it should be preferable to use the newest version by default. Or are manual workarounds to the .yml files looked down upon?

@ocefpaf
Copy link
Member

ocefpaf commented Oct 14, 2016

I agree entirely with @asmeurer. BTW that was the original setup we had before this package was introduced. Notice that pinning only when necessary was also easier before because the conda/conda-build versions where in conda-smithy and people could easily see them in the CIs configuration explicitly, instead of digging into layers of dubious advantages. Also, before this package we did not had to http://xkcd.com/1739/ like in #29 😄

@asmeurer
Copy link
Member Author

Another (advantage?) to manually pinning in *.yml is that it will need to be manually kept in with each rerender, meaning the rerenders provide an impetus to check if the pinning is still necessary.

@ocefpaf
Copy link
Member

ocefpaf commented Oct 14, 2016

Another (advantage?) to manually pinning in *.yml is that it will need to be manually kept in with each rerender, meaning the rerenders provide an impetus to check if the pinning is still necessary.

That "advantage?" was part of Phil's original design BTW.

@ocefpaf
Copy link
Member

ocefpaf commented Nov 25, 2016

@pelson it seems that @jjhelmus already implemented the extra config argument in e35cc08

But I see that there are other calls to bldpkg_path in the script. Those are addressed in
#39 by @shadowwalkersb BTW.

So the only issue here is the rendering of the conda-forge-build-setup-feedstock itself.

@jakirkham
Copy link
Member

We are now on conda-build 2. Details of what went into the switch and related discussion are in issue ( #40 ).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants