Skip to content
This repository has been archived by the owner on Apr 9, 2020. It is now read-only.

Pin conda-build to version 1.x #27

Merged
merged 6 commits into from
Aug 31, 2016

Conversation

jjhelmus
Copy link
Contributor

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

Please bump version to 3.1.2 (i.e. the patch number).

@jakirkham
Copy link
Member

LOL. This is fun. 😒

Using Anaconda API: https://api.anaconda.org
Traceback (most recent call last):
  File "/feedstock_root/ci_support/upload_or_check_non_existence.py", line 124, in <module>
    main()
  File "/feedstock_root/ci_support/upload_or_check_non_existence.py", line 104, in main
    exists = built_distribution_already_exists(cli, meta, owner)
  File "/feedstock_root/ci_support/upload_or_check_non_existence.py", line 24, in built_distribution_already_exists
    fname = bldpkg_path(meta)
TypeError: bldpkg_path() missing 1 required positional argument: 'config'

I think we are going to have to do some pinnings in the CI scripts too. It's ugly, but tolerable for now.

@@ -11,5 +11,8 @@ conda config --set add_pip_as_python_dependency false
conda update -n root --yes --quiet conda
conda install -n root --yes --quiet jinja2 conda-build anaconda-client

# KLUDGE to work around changes in conda-build 2.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# -> ::

@jjhelmus
Copy link
Contributor Author

I think we are going to have to do some pinnings in the CI scripts too. It's ugly, but tolerable for now.

Agreed, Circle seems do-able, but how about Travis and AppVeyor?

@jakirkham
Copy link
Member

Would just add a line after here in .travis.yml and after here in appveyor.yml.

Comments referencing this PR would be nice.

@jjhelmus
Copy link
Contributor Author

Oh wait, this recipe doesn't use itself, so patching is not as hard as I though.

@jakirkham
Copy link
Member

Oh wait, this recipe doesn't use itself, so patching is not as hard as I though.

Yeah, I have been waiting for that to bite us, but we are lucky thus far. Will give it some more thought. Admittedly the same kludgy things we are doing here should still work in that case. Though ideally we would bootstrap this somehow.

@jakirkham
Copy link
Member

LGTM. Will merge when it passes, thanks for putting this together.

@jjhelmus
Copy link
Contributor Author

No problem. I'll add the issue from conda-smithy to this repo so as a reminder to remove this kludge once the upload script is fixed.

@jakirkham
Copy link
Member

Also opened issue ( #29 ) to discuss how we handle building bootstrapping conda-forge-build-setup.

@asmeurer
Copy link
Member

Checks pass. Should this get merged?

@asmeurer
Copy link
Member

And once this is merged, will I need to wait for my feedstock to be re-rendered, or will it just work?

@jakirkham jakirkham merged commit c8d2f58 into conda-forge:master Aug 31, 2016
@jakirkham
Copy link
Member

Awesome. Thanks for the message.

Nope. Should just work as that feedstock already uses conda-forge-build-setup.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants