-
-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Please bump version to |
LOL. This is fun. 😒
I think we are going to have to do some pinnings in the CI scripts too. It's ugly, but tolerable for now. |
@@ -11,5 +11,8 @@ conda config --set add_pip_as_python_dependency false | |||
conda update -n root --yes --quiet conda | |||
conda install -n root --yes --quiet jinja2 conda-build anaconda-client | |||
|
|||
# KLUDGE to work around changes in conda-build 2.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#
-> ::
Agreed, Circle seems do-able, but how about Travis and AppVeyor? |
Oh wait, this recipe doesn't use itself, so patching is not as hard as I though. |
Yeah, I have been waiting for that to bite us, but we are lucky thus far. Will give it some more thought. Admittedly the same kludgy things we are doing here should still work in that case. Though ideally we would bootstrap this somehow. |
LGTM. Will merge when it passes, thanks for putting this together. |
No problem. I'll add the issue from conda-smithy to this repo so as a reminder to remove this kludge once the upload script is fixed. |
Also opened issue ( #29 ) to discuss how we handle building bootstrapping |
Checks pass. Should this get merged? |
And once this is merged, will I need to wait for my feedstock to be re-rendered, or will it just work? |
Awesome. Thanks for the message. Nope. Should just work as that feedstock already uses |
should address conda-forge/conda-smithy#282