add bldpkg_path_wrapper() #39
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
If this is still a live PR, then I'm pretty much in favour of merging as is. |
|
Closing and reopening to restart CIs. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
| config = Config() | ||
| fname = bldpkg_path(meta, config) | ||
| except TypeError: | ||
| # conda-build < 2.0.0 takes a single config argument |
There was a problem hiding this comment.
We should update this comment because latest conda-build 2 behaves like conda-build 1 and no longer take the config argument.
There was a problem hiding this comment.
If conda-build 2 behaves the same, doesn't this PR become unnecessary along with PR #34 ?
There was a problem hiding this comment.
There is more to come. Maybe we should take a second look at latest conda-build.
|
Probably also should rebase to get updated behavior for CircleCI. |
|
AppVeyor won't restart due to GitHub rate limiting. FWIW the message in the AppVeyor console is totally clear on this point. |
|
Rebased. |
|
In |
|
Agreed. I just leaner about |
|
What do you think about @jjhelmus's suggestion above, @shadowwalkersb? Would it be possible to update this PR accordingly? |
|
Will that do ( b89ca05 ) ? |
|
I've figured out the problem with my CircleCI PRs. This should pass, hopefully. |
| try: | ||
| from conda_build.api import get_output_file_path | ||
| except ImportError: | ||
| from conda_build.build import bldpkg_path as get_output_file_path |
|
Anything else here? |
|
Thanks @shadowwalkersb. However I think this is now unnecessary as we no longer support |
Adds on PR #34 to fix calls to
bldpkg_path().