fix: add --target-platform for rattler-build invocation
#2070
Conversation
| @@ -118,6 +118,7 @@ else | |||
| {{ BUILD_CMD }} --recipe "${RECIPE_ROOT}" \ | |||
| -m "${CI_SUPPORT}/${CONFIG}.yaml" \ | |||
| ${EXTRA_CB_OPTIONS:-} \ | |||
| --target-platform "${HOST_PLATFORM}" \ | |||
There was a problem hiding this comment.
Can we call it --host-platform in rattler-build? Pretty please!
There was a problem hiding this comment.
We can definitely add an alias but would you also want to change target_platform variable everywhere in config files / recipes? We kept with conda-build here ... but host_platform does make some sense, too.
There was a problem hiding this comment.
Yeah an alias is the best we can do. We'll need a breaking change in conda-build to clean this up more.
There was a problem hiding this comment.
Make host_platform the canonical thing and make target_platform an alias is the best option.
There was a problem hiding this comment.
That is make target_platform env variable and jinja variable a alias to host_platform when target_platform is not explicitly given.
There was a problem hiding this comment.
Sure what order do we want to do things in? We are talking about three PRs including this one.
There was a problem hiding this comment.
I think we should merge this, and open an issue on rattler-build for an alias.
There was a problem hiding this comment.
I made an issue for this on the smithy side: #2072. We can revisit once rattler-build has the option.
There was a problem hiding this comment.
Also this one: prefix-dev/rattler-build#1075
There was a problem hiding this comment.
@isuruf you ok resolving this comment for now and going ahead with this PR?
|
Added the news entry. |
wolfv
changed the title
--target-platform for rattler-build--target-platform for rattler-build and SYSTEM_VERSION_COMPAT=0 on macOS
|
squashed and linted, sry! |
|
Testing here: conda-forge/jolt-physics-feedstock#2 |
|
@isuruf can you resolve your I removed the SYSTEM_VERSION_COMPAT stuff as this will hopefully be fixed by the 11.0 rebuild. |
wolfv
changed the title
--target-platform for rattler-build and SYSTEM_VERSION_COMPAT=0 on macOS--target-platform for rattler-build invocation
rattler-build does not read the
target_platformfrom the variant config file. We need to explicitly pass it on the command line.