Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rerender using new-conda-smithy #2

Merged

Conversation

nichmor
Copy link
Contributor

@nichmor nichmor commented Aug 16, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/recipe.yaml:

This is a rattler-build recipe and not yet lintable. We are working on it!

@baszalmstra
Copy link
Member

@conda-forge-admin, please rerender

Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found some lint.

Here's what I've got...

For recipe/recipe.yaml:

  • The top level meta keys are in an unexpected order. Expecting ['context', 'package', 'source', 'build', 'requirements', 'about', 'extra'].
  • The recipe must have some tests.

Copy link

github-actions bot commented Sep 26, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

@wolfv
Copy link
Member

wolfv commented Sep 29, 2024

@conda-forge-admin, please rerender

One more time pls!

@wolfv
Copy link
Member

wolfv commented Sep 29, 2024

@baszalmstra should .dll files go into bin/ or lib/? This package currently installs both dll and lib into lib/.

@wolfv
Copy link
Member

wolfv commented Oct 1, 2024

This should be iiiit

@baszalmstra baszalmstra merged commit be2718f into conda-forge:main Oct 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants