-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the checks. [skip appveyor] #14
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@@ -6,7 +6,7 @@ export ERL_TOP="$(pwd)" | |||
./configure --with-ssl="${PREFIX}" --prefix="${PREFIX}" --without-javac \ | |||
--with-libatomic_ops="${PREFIX}" --enable-m${ARCH}-build | |||
make | |||
make release_tests | |||
#make release_tests | |||
cd "${ERL_TOP}/release/tests/test_server" | |||
${ERL_TOP}/bin/erl -s ts install -s ts smoke_test batch -s init stop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So these two lines above are tests too. Even though they don't look it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They did look it, but I'm going to narrow it down slowly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, so those 2 lines will fail without running make release_tests
though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented them too. Let's see what happens now.
So, CircleCI failed to pull the Docker image. That is probably a fluke. However, Travis CI failed to run the other two test lines because the directory doesn't exist. Maybe we need to comment all three lines after all? |
Also this appears to be an interesting note in the docs (under testing).
|
Yep that fixes it. Will put this in a formal PR. |
Removed the Linux build from this (build number 3) as it doesn't correspond to a proper state of the recipe. There is already a Linux build from The OS X build already existed so was unaffected by these changes. |
xref: #1