Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the checks. [skip appveyor] #14

Closed
wants to merge 2 commits into from
Closed

Removed the checks. [skip appveyor] #14

wants to merge 2 commits into from

Conversation

pelson
Copy link
Member

@pelson pelson commented Jul 16, 2016

xref: #1

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@@ -6,7 +6,7 @@ export ERL_TOP="$(pwd)"
./configure --with-ssl="${PREFIX}" --prefix="${PREFIX}" --without-javac \
--with-libatomic_ops="${PREFIX}" --enable-m${ARCH}-build
make
make release_tests
#make release_tests
cd "${ERL_TOP}/release/tests/test_server"
${ERL_TOP}/bin/erl -s ts install -s ts smoke_test batch -s init stop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So these two lines above are tests too. Even though they don't look it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They did look it, but I'm going to narrow it down slowly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, so those 2 lines will fail without running make release_tests though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented them too. Let's see what happens now.

@jakirkham
Copy link
Member

So, CircleCI failed to pull the Docker image. That is probably a fluke. However, Travis CI failed to run the other two test lines because the directory doesn't exist. Maybe we need to comment all three lines after all?

@jakirkham
Copy link
Member

Also this appears to be an interesting note in the docs (under testing).

On builds without crypto, ssl and ssh there is a failed test case for undefined functions. Verify that the failed test case log only shows calls to skipped applications.

@jakirkham
Copy link
Member

Yep that fixes it. Will put this in a formal PR.

@jakirkham jakirkham mentioned this pull request Aug 9, 2016
@jakirkham jakirkham closed this in #15 Aug 9, 2016
@jakirkham jakirkham deleted the no_check branch August 9, 2016 12:27
@jakirkham
Copy link
Member

Removed the Linux build from this (build number 3) as it doesn't correspond to a proper state of the recipe. There is already a Linux build from master with build number 5.

The OS X build already existed so was unaffected by these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants