Fix CircleCI uploads #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Bumped the build number as the build has changed. Also this gives us a chance to see if this is in fact working on CircleCI again as a sanity check. |
Merged
| # | ||
| # https://github.com/conda-forge/erlang-feedstock/issues/1 | ||
| # | ||
| if [ "$(uname)" == "Linux" ] |
There was a problem hiding this comment.
Would help if we skipped Linux. 🤦 Please see PR ( #17 ).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
Closes #7
Closes #14
After some issues trying to get packages to upload from CircleCI on Linux, it seems like this has the magic ingredients. This was determined through trial and error in PR ( https://github.com//pull/14 ).
Basically we skip the tests on Linux. This makes me a little nauseous as we should be fixing whatever is going wrong with the tests to get the upload to happen not ignoring them outright. However, we need to be practical. Doing this gives use somewhere to start.
cc @pelson