Add Windows recipe #2

shadowwalkersb · 2016-08-29T20:28:31Z

No description provided.

conda-forge-linter · 2016-08-29T20:28:34Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form.

jakirkham · 2016-08-29T20:33:22Z

Please add python to build requirements for Windows only. Also please add it the test requirements for Windows only with Python version specified like so python {{ environ['PY_VER'] + '*' }}.

conda-forge-linter · 2016-08-29T20:33:33Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham · 2016-08-29T20:33:40Z

Once the above is addressed, please re-render.

jakirkham · 2016-08-29T20:34:17Z

recipe/meta.yaml

@@ -11,7 +11,7 @@ source:

 build:
  number: 0
-  skip: true                      # [not linux]
+  skip: false


Actually OS X is still not supported. So it should skip OS X.

How about this?

skip: true # [osx]

jakirkham · 2016-08-29T20:55:37Z

To get the CI files we actually generate them. Not sure that happened here. Please do the following.

conda install -y -n root conda-smithy
cd <some feedstock>
conda smithy rerender
Commit all changes and push.

jakirkham · 2016-08-29T20:57:48Z

recipe/run_test.bat

+        echo "%%f% NOT found."
+        exit 1
+    )
+)


This can be absorbed above. Please see this.

jakirkham · 2016-08-29T21:33:10Z

Should add the CircleCI failure should be fixed in master (unless there are other causes for failure in this PR). So merging with that should solve this build failure.

jakirkham · 2016-08-29T23:42:28Z

Seems to have merge conflicts. 😕 Maybe try merging with master.

jakirkham · 2016-08-29T23:56:10Z

So we still need that re-rendering. Would recommend merging with master here. May need to fetch first though.

shadowwalkersb · 2016-08-30T00:02:56Z

IMO, these instructions should go into Update a Package section on the home page.

conda install -y -n root conda-smithy

cd <some feedstock>

conda smithy rerender

Commit all changes and push.

jakirkham · 2016-08-30T00:19:37Z

They aren't always needed. Only when adding things like support for other CIs or some other special cases does one actually need to do this. Adding instructions somewhere is a good idea, but the webpage doesn't quite seem like the right spot. Perhaps this Readme or the docs.

jakirkham · 2016-08-30T00:22:42Z

recipe/meta.yaml

+    - if not exist %LIBRARY_INC%\\GL\\freeglut_std.h exit 1   # [win and py27]
+    - if not exist %LIBRARY_INC%\\GL\\glut.h         exit 1   # [win and py27]
+    - if not exist %LIBRARY_LIB%\\freeglut.lib       exit 1   # [win and py27]
+    - if not exist %LIBRARY_BIN%\\freeglut.dll       exit 1   # [win and py27]


Why do these need Python selectors? Should just be Windows right?

Sorry. When you pointed me to the boost recipe, I assumed we needed python selectors, too. I guess, it was the if not exist .... part only.

shadowwalkersb · 2016-08-30T00:27:13Z

Hmm, I see. The Readme didn't catch my attention. I guess, I saw the beginning and the cartoon, but the smithy stuff, I just overlooked. The docs, I don't remember seeing them before. I'll have to take a closer look at both. Thanks! Also, thanks for the boost link above. So, that is what Jinja is. Now, I can dive into that, too!

shadowwalkersb · 2016-08-30T02:59:32Z

Is this a typo in the documentation?

test:
  requires:
    nose

http://conda.pydata.org/docs/building/meta-yaml.html#test-requirements

Shouldn't it be

test:
  requires:
    - nose

Update: Just submitted a PR (conda/conda-docs#338).

shadowwalkersb · 2016-08-31T15:23:55Z

Are there any reasons not to accept this PR? I don't want to upload the package to my own channel to be able to use it if not completely necessary.

jakirkham · 2016-08-31T15:54:24Z

recipe/meta.yaml

@@ -11,21 +11,32 @@ source:

 build:
  number: 0


Please bump the build number to 1.

jakirkham · 2016-08-31T15:55:12Z

Please add yourself as a maintainer by adding your GitHub handle to the recipe-maintainers list.

jakirkham · 2016-08-31T15:56:42Z

Are there any reasons not to accept this PR?

Not that I know of. There are some minor easy final things. Otherwise 👍 for merging. Just busy is all. 😄

shadowwalkersb · 2016-09-01T15:33:17Z

I am not sure why AppVeyor build was canceled. How do we rebuild, if there aren't any other problems?

jakirkham · 2016-09-01T15:57:30Z

Sorry, I canceled it yesterday because we had to get a critical fix out for a bug that was causing all builds to fail and all uploads to fail. See PR ( conda-forge/conda-forge-build-setup-feedstock#27 ).

Will restart this now. Thanks for the reminder.

jakirkham · 2016-09-01T17:38:21Z

Build had failed, but failure was spurious. Restarted.

shadowwalkersb · 2016-09-01T21:09:08Z

... and failed again?!

shadowwalkersb · 2016-09-02T19:21:28Z

ping

jakirkham · 2016-09-02T19:50:02Z

Restarted again.

shadowwalkersb · 2016-09-03T03:31:08Z

Great, it is done!

shadowwalkersb · 2016-09-03T05:53:42Z

Why is circle_ci check reported here the one from my circle_ci?
There is a problem with 64-bit architecture on Windows. It runs the 32-bit generator. We don't check for that in tests. So, the tests pass.

jakirkham · 2016-09-03T06:25:10Z

Because CircleCI checks out the head ref of the PR and not the merge ref. If you rebase/merge with master, it should be fine.

shadowwalkersb · 2016-09-07T14:39:14Z

Is it OK to rebase and force-push? Or should I merge?

shadowwalkersb · 2016-09-07T14:42:36Z

I had merged, ba1d418.

jakirkham · 2016-09-07T14:45:28Z

Either is fine with me.

jakirkham · 2016-09-22T14:00:47Z

Toggling to retest.

jakirkham · 2016-09-22T20:10:22Z

Could you please try merging into master again? It appears that CircleCI is still running into a fixed issue in master.

shadowwalkersb · 2016-09-22T20:17:53Z

It is merged/rebased. Anything else I can do? I am allowing maintainer-edits, if it helps.

shadowwalkersb · 2016-09-22T20:20:56Z

I've deleted my other remote branch. Does that help?

jakirkham · 2016-09-22T20:29:47Z

Could you try deleting the CircleCI project for this feedstock on your org? I think it might be confusing things.

shadowwalkersb · 2016-09-22T20:38:53Z

Delete empty commits and force-push or is it OK this way?

jakirkham · 2016-09-22T20:39:14Z

Nope this is fine. Thanks.

jakirkham · 2016-09-22T20:42:14Z

Thanks @shadowwalkersb.

jakirkham · 2016-09-22T20:43:43Z

Soon (within 24-hrs) you should get an email that invite you to join conda-forge, @shadowwalkersb. Once accepted you will be added to a team with the same name as this recipe. Those will give you permissions on the feedstock (repo) for this recipe.

Make sure when proposing any change that you go through the typical GitHub workflow of forking the feedstock and making changes in your fork that you PR back. Once merged CIs will build and deploy any changes you make.

Please let us know if you have any questions and welcome to conda-forge. :)

shadowwalkersb · 2016-09-22T20:46:24Z

Thanks! Pleasure to be onboard!

shadowwalkersb · 2016-09-27T20:33:18Z

When is the windows version of freeglut going to be available on anaconda's conda-forge channel?

shadowwalkersb · 2016-09-28T01:05:51Z

appveyor.yml

+    - cmd: conda install -n root --quiet --yes conda-forge-build-setup
+    - cmd: run_conda_forge_build_setup
+    # This needs to be updated to conda-forge channel before PR
+    - appveyor DownloadFile "https://raw.githubusercontent.com/shadowwalkersb/conda-smithy/fix-appveyor-vc9-64/appveyor/setup_x64.bat"


I just realized that this was left over and made it to master.

Re-rendering in PR ( #7 ), which will strip this out. Also added a build number bump to get a clean build without this change.

So this fails without it, but it is because we are using the VS generator. If we switch to NMake, I expect this goes away.

There is a package that was in the works in PR ( conda-forge/staged-recipes#617 ), which needs to be revitalized. It does a similar thing to what is being done here. Could you please take a look at it? If you have time, it would great to get that package fixed up so it could clear staged-recipes.

shadowwalkersb · 2016-10-11T00:28:44Z

When is the windows version of freeglut going to be available on anaconda's conda-forge channel? It is still linux only.

jakirkham · 2016-10-12T02:27:56Z

That's pretty strange. It should already be up there. Could you please open a new issue, @shadowwalkersb ?

jakirkham · 2016-10-13T04:26:21Z

conda-forge.yml

 appveyor:
  secure:
-    BINSTAR_TOKEN: MP4hZYylDyUWEsrt3u3cod2sbFeRwUziH02mvQOdbjsTO/l1yIxDkP/76rSIjcGC
+    BINSTAR_TOKEN: 4ef5IUakGqqw7GSfuIp93Q4MdAC1VnweE1kFVAOUs6ThPDQWBqNpGaq6ZuEbX1FL


Reverted in PR ( #12 ).

jakirkham · 2016-10-13T04:27:00Z

appveyor.yml

+  CONDA_PY: "27"
+  BINSTAR_TOKEN:
+    # The BINSTAR_TOKEN secure variable. This is defined canonically in conda-forge.yml.
+    secure: 4ef5IUakGqqw7GSfuIp93Q4MdAC1VnweE1kFVAOUs6ThPDQWBqNpGaq6ZuEbX1FL


Changed to the original secure token in PR ( #12 ).

jakirkham reviewed Aug 29, 2016
View reviewed changes

recipe/run_test.bat

echo "%%f% NOT found."

exit 1

)

)

Copy link

Member

jakirkham Aug 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be absorbed above. Please see this.

jakirkham reviewed Aug 30, 2016
View reviewed changes

jakirkham reviewed Aug 31, 2016
View reviewed changes

recipe/meta.yaml

@@ -11,21 +11,32 @@ source:

build:

number: 0

Copy link

Member

jakirkham Aug 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the build number to 1.

shadowwalkersb added 2 commits September 7, 2016 09:34

add build features, use CMAKE_GENERATOR

5195ace

rerender

43e0829

jakirkham closed this Sep 22, 2016

jakirkham reopened this Sep 22, 2016

empty commit to trigger CI

28ed6c7

remove Circle-CI and Travis from org

793b403

jakirkham approved these changes Sep 22, 2016

View reviewed changes

jakirkham merged commit d713f84 into conda-forge:master Sep 22, 2016

shadowwalkersb commented Sep 28, 2016

View reviewed changes

This was referenced Sep 28, 2016

Vs2008 appveyor cmake conda-forge/staged-recipes#617

Closed

Re-render with conda-smithy version 1.2.0 #7

Merged

shadowwalkersb mentioned this pull request Oct 12, 2016

Windows package not uploaded to anaconda's conda-forge channel after merging PR #10

Closed

jakirkham reviewed Oct 13, 2016

View reviewed changes

Add Windows recipe #2

Add Windows recipe #2

Conversation

shadowwalkersb commented Aug 29, 2016

conda-forge-linter commented Aug 29, 2016

jakirkham commented Aug 29, 2016

conda-forge-linter commented Aug 29, 2016

jakirkham commented Aug 29, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakirkham commented Aug 29, 2016

Choose a reason for hiding this comment

jakirkham commented Aug 29, 2016

jakirkham commented Aug 29, 2016

jakirkham commented Aug 29, 2016

shadowwalkersb commented Aug 30, 2016 • edited Loading

jakirkham commented Aug 30, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shadowwalkersb commented Aug 30, 2016

shadowwalkersb commented Aug 30, 2016 • edited Loading

shadowwalkersb commented Aug 31, 2016

Choose a reason for hiding this comment

jakirkham commented Aug 31, 2016

jakirkham commented Aug 31, 2016

shadowwalkersb commented Sep 1, 2016 • edited Loading

jakirkham commented Sep 1, 2016 • edited Loading

jakirkham commented Sep 1, 2016

shadowwalkersb commented Sep 1, 2016

shadowwalkersb commented Sep 2, 2016

jakirkham commented Sep 2, 2016

shadowwalkersb commented Sep 3, 2016

shadowwalkersb commented Sep 3, 2016

jakirkham commented Sep 3, 2016

shadowwalkersb commented Sep 7, 2016 • edited Loading

shadowwalkersb commented Sep 7, 2016

jakirkham commented Sep 7, 2016

jakirkham commented Sep 22, 2016

jakirkham commented Sep 22, 2016

shadowwalkersb commented Sep 22, 2016

shadowwalkersb commented Sep 22, 2016

jakirkham commented Sep 22, 2016

shadowwalkersb commented Sep 22, 2016

jakirkham commented Sep 22, 2016

jakirkham commented Sep 22, 2016

jakirkham commented Sep 22, 2016

shadowwalkersb commented Sep 22, 2016

shadowwalkersb commented Sep 27, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shadowwalkersb commented Oct 11, 2016

jakirkham commented Oct 12, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shadowwalkersb commented Aug 30, 2016 •

edited

Loading

shadowwalkersb commented Aug 30, 2016 •

edited

Loading

shadowwalkersb commented Sep 1, 2016 •

edited

Loading

jakirkham commented Sep 1, 2016 •

edited

Loading

shadowwalkersb commented Sep 7, 2016 •

edited

Loading