Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections of recipes needing attention? #161

Closed
msarahan opened this issue Mar 19, 2016 · 94 comments
Closed

Collections of recipes needing attention? #161

msarahan opened this issue Mar 19, 2016 · 94 comments
Labels

Comments

@msarahan
Copy link
Member

I'm already feeling overwhelmed with keeping track of recipes that either need Windows modification or need attention at some later date (e.g. to include some Continuum changes that I know are available)

Is there any way we can consolidate these recipes/repos into a list that is easier to approach and to track? Perhaps a wiki page? Some Google spreadsheet? Create issues on those repos and assign people to them?

@jakirkham
Copy link
Member

I'll try to come up with a list here. Sorry you are feeling overwhelmed. I'll try to restrict further questions and/or direct others to this issue so it can remain manageable.

@msarahan
Copy link
Member Author

No problem - I'm overwhelmed with normal Continuum work anyway. It's life as normal. I just don't want to lose track of things here that I could help with - and I feel bad that I may have already missed a few instances where you all have pinged me.

@jakirkham
Copy link
Member

No problem - I'm overwhelmed with normal Continuum work anyway.

My hope is that conda-forge will in the long run make this less so. I expect everyone will enjoy a few less pings about updates to packages or at least can respond "please submit a PR". 😄

Admittedly, that is not the case while we are still try to figure out how it should work.

I just don't want to lose track of things here that I could help with...

Absolutely, and I should be doing a better job at compiling these somewhere so we can track them.

...and I feel bad that I may have already missed a few instances where you all have pinged me.

No need to feel bad. There is just a lot going on here.

@pelson
Copy link
Member

pelson commented Mar 20, 2016

The todo list feature works really well in gh issues - that is certainly one option @jakirkham.

@msarahan
Copy link
Member Author

I use the (free) zenhub chrome plugin. It provides a few additional nice
views as well. I'm cool with any solution aside from @msarahan mentions -
those just aren't nicely searchable/collectable, and I miss them
sometimes. Labels on PRs, or assignment of PRs, or merged PRs without
Windows stuff, plus an issue with a label or an assignment.

I think there are a few labels we would need:

  1. Request Continuum recipe update
  2. Needs Windows fix
  3. Needs build from source

Feel free to add more - I just think these are ones that would help me help
you the most.

On Sun, Mar 20, 2016 at 4:30 AM Phil Elson notifications@github.com wrote:

The todo list feature works really well in gh issues - that is certainly
one option @jakirkham https://github.com/jakirkham.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#161 (comment)

@ocefpaf
Copy link
Member

ocefpaf commented Mar 20, 2016

  1. Request Continuum recipe update
  2. Needs Windows fix
  3. Needs build from source

👍 to all that. Not sure if we can define label to an organization though. I guess they are defined at project level, right?

I use the (free) zenhub chrome plugin.

Never used, but I am OK for testing something new.

@msarahan
Copy link
Member Author

Never used, but I am OK for testing something new.

You don't need to. It's just a way of viewing the same information that Github already has in different ways. It provides todo-lists also, but AFAICT, those are private. Still - give it a shot. I find it improves my ability to track stuff on Github.

@msarahan
Copy link
Member Author

I guess they are defined at project level, right?

Yeah... bummer. Seems we're not the first people to think of this:

https://github.com/repo-utils/org-labels

also

isaacs/github#371

@ocefpaf
Copy link
Member

ocefpaf commented Mar 20, 2016

Yeah... bummer. Seems we're not the first people to think of this

It is one of those things you never thought you'd use and one day you cannot live without it 😀

@jakirkham
Copy link
Member

I was looking at different ways to help us track what is going on as I agree it is kind of busy here and it is hard to tell sometimes (especially with so many repos 😉).

These appear to be free for open source. This seems like it might help ( https://sprint.ly/ ) the management side. This ( https://zube.io/ ) is pretty similar. Also, this ( https://waffle.io/ ) is ok for single repos like this one. Here is another neat one ( https://codetree.com/ ) that looks potentially good for issue tracking. Another similar one ( http://gitlo.co/ ).

These are interesting, but need to be paid for somehow. This ( https://huboard.com/ ) could be tried, but I can't seem to find a good example of it in use. This ( https://www.blossom.co/ ) is similar to the first two.

@jakirkham
Copy link
Member

BTW, I tried enabling ZenHub for the org. Not sure how this ends up working as I have only begun using it. Will this let us use the same ZenHub or does every user setup their own? Anyways feel free to share feedback. As it is free for open source, we can use this for as long as we like.

@msarahan
Copy link
Member Author

I don't see anything set up on ZenHub. I'm not sure if it is just sort of a local tool, storing its information in the plugin, or if it has some sharable content that other people can see. Please do not feel compelled to use it on my behalf. I'm happy to try any other tool - I just want something (anything) that can help unify labels. I feel like if we get the labels stuff done right, then anyone will be able to use any tool to track that metadata appropriately.

@dopplershift
Copy link
Member

I see stuff when I go to the "boards" tab. The information should be synchronized to zenhub's servers--I've used it for collaboration elsewhere.

@msarahan
Copy link
Member Author

Yeah, I see stuff on the boards, but only for the two repos I linked myself. Wasn't sure if anyone had created/linked any other repos. Does each new feedstock need to be manually added?

@pelson
Copy link
Member

pelson commented Mar 21, 2016

Does each new feedstock need to be manually added?

As a helpful tip, more than a thing you might actually want to do for this:

If you can register with an API it can be batched up with the conda-smithy feedstocks cli (note, I've just found and fixed a bug, so you need a 0.4.* version:

feedstocks apply-cloned echo "foo {} {FEEDSTOCK_NAME}"

You would want to clone all of the feedstocks first though:

feedstocks clone

@jakirkham
Copy link
Member

Bit of a tangent, but could we get a copy of the snappy recipe in here? It's good that we do have a package of snappy available to us, but it would be nice to have the recipe moved over. Alternatively, I can just write a recipe and tweaks can be backported as there is time. However, you would like to do it.

@msarahan
Copy link
Member Author

@groutr - can you move the snappy recipe any time soon?

@groutr
Copy link
Contributor

groutr commented Mar 22, 2016

sure. I can do it in the next day or two.

@jakirkham
Copy link
Member

I think we need the Windows build incantation for snappy.

@jakirkham
Copy link
Member

Also, we could probably use those Windows build incantations for OpenCV.

@patricksnape
Copy link
Contributor

Given that this Windows black magic seems to really be necessary for all multi-Python version projects - would it not make sense for that information to just be provided as an ENV variable? Or maybe a small script that is on the conda path that can be called?

@jakirkham
Copy link
Member

Or maybe a small script that is on the conda path that can be called?

This would be ideal.

@jakirkham
Copy link
Member

So, this is very special. It appears the hdf5 package is in conflict with itself on Windows. Bonus points for anyone with a working Windows dev environment who can figure out this brainteaser ( conda-forge/hdf5-feedstock#1 ). Interestingly this was building before.

@jakirkham
Copy link
Member

If someone has time and a Windows environment up and working, I would appreciate guidance on getting h5py working for Windows in this PR ( conda-forge/h5py-feedstock#1 ) or if you want to submit your own PR feel free.

@jakirkham
Copy link
Member

Could you please make sure this PR ( #194 ) has the right Windows magic for compiler selection, @msarahan?

@jakirkham
Copy link
Member

So, I have been working on protobuf support for C++ ( conda-forge/protobuf-feedstock#4 ). I have what looks so far to be working Windows support. Though I would appreciate feedback from others on anything else this might need.

@jakirkham
Copy link
Member

Could anyone with access please provide the YAML recipe? Appears that we can build it with C++ support, but that is not currently happening. Doesn't even have to be a pretty recipe. We can clean it up here.

@msarahan
Copy link
Member Author

Will do tomorrow.

On Mon, Apr 18, 2016, 21:55 jakirkham notifications@github.com wrote:

Could anyone with access please provide the YAML recipe? Appears that we
can build it with C++ support, but that is not currently happening. Doesn't
even have to be a pretty recipe. We can clean it up here.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#161 (comment)

@jakirkham
Copy link
Member

Actually I started hacking on one just to see how far I could get it to go. Maybe just your feedback should be enough.

Though I was wrong about C++ support. That will require another yaml library. Will have to check and see that they don't clash with the C version.

@jakirkham
Copy link
Member

See this PR ( #397 ) for the yaml recipe that I hacked together. Windows side is at best a guess of what should work. Will see how it goes. If there is anything else I missed or is nice to add, please let me know.

@msarahan
Copy link
Member Author

I copied the scripts from #751 manually (copy/paste), locally, and things work fine. I have tagged 1.21.1. Packages should be available soon, but I'll post here when they are.

@jakirkham
Copy link
Member

Did you use the docker container?

@jakirkham
Copy link
Member

Thanks @msarahan. 😄

@msarahan
Copy link
Member Author

No, just built the code for Mac. Sorry, tried docker, but I'm using the beta, and volume mounts don't seem to be working. =(

I hope 1.21.1 is a solid release for us.

@msarahan
Copy link
Member Author

Appveyor is showing some issues with Windows on the 3.4 stuff (as usual). You should probably expect some failures there. I'm working on it. I hope that the rest of the release will still be useful.

@jakirkham
Copy link
Member

Would you mind taking a look at this PR ( conda-forge/openblas-feedstock#6 ) when you have a chance, @msarahan? I think this is the fastest path forward ATM without winding up in trouble. It appears the libgfortran that is shipped from defaults has a newer ABI than the one pulled from the gcc compiler. So, I have chosen to use that directly on Linux and leave OS X basically unchanged as I have not heard any complaints about the latter.

@jakirkham
Copy link
Member

Friendly nudge for reviewing this PR ( conda-forge/mpc-feedstock#3 ) when you have a chance, @msarahan.

cc @isuruf

@jakirkham
Copy link
Member

Did the symlinks get removed from conda, @msarahan?

cc @gillins

@msarahan
Copy link
Member Author

There's not enough context here. Do you mean the activate scripts? They have not been removed AFAIK. Last I dealt with them, I wrote a test to ensure that they exist.

@jakirkham
Copy link
Member

Yeah, the symlinks to activate, conda, and deactivate.

Interesting, well, we mysteriously are not seeing them get packaged even in cases where we have not released the conda-build pinning. For instance, see libtiff version 4.0.6 build number 5 and gdal version 2.1.0 build number 6. Not sure why it is and are trying to figure it out. Even though this is a win, it is a bit disconcerting as we don't understand the reason.

@jakirkham
Copy link
Member

Could you please take a look at the conda recipe build for Windows ( #656 ), @msarahan? Seem to be having some issues with always_include_files.

@jakirkham
Copy link
Member

Could you please double check that the toolchain is now correct w.r.t. to Windows in this PR ( conda-forge/toolchain-feedstock#12 ), @msarahan? It wasn't actually doing anything on Windows previously, but it would be good to make sure it is setup correctly if starts to be needed there.

@jakirkham
Copy link
Member

As you have time @msarahan this PR ( #658 ) needs some TLC probably in the form of a conda-build patch, but it is a bit subtle. Again not a rush or anything just something I think you will have some good insight on.

@jakirkham
Copy link
Member

Got a very strange error when trying to upgrade conda-smithy. Don't think it is related to the changes we made. Please take a look when you have a chance @msarahan. Here is the PR ( conda-forge/conda-smithy-feedstock#29 ).

@jakirkham
Copy link
Member

Could you please review PR ( conda-forge/cmake-feedstock#8 ) when you have a chance, @msarahan?

@jakirkham
Copy link
Member

While you are looking at weird activation issues on Windows, maybe this one will catch your attention, @msarahan?

@jakirkham
Copy link
Member

@msarahan @patricksnape, could either or both of you please take a look at a couple PRs @jjhelmus has added to python. They seem crucial for Windows, but I don't really feel qualified to comment on them. If these are fixing major issues, I'd like to see them get out there soon, but also want to be sure they are working properly. Please see PR ( conda-forge/python-feedstock#52 ) for 3.4 and PR ( conda-forge/python-feedstock#51 ) for 3.5. They are very similar in nature FWICT.

@jakirkham
Copy link
Member

This can probably be done at your own pace (not sure @jjhelmus' timeline). Though it would be nice if some people could take a look at the proposed Python 2.7 recipe ( conda-forge/python-feedstock#62 ) and see if it makes sense or needs changes.

@jakirkham
Copy link
Member

Could you please take a look at this recipe for nsis ( #1089 ), @msarahan? I'm trying to get it to build from source with scons, but seem to be having some issues. We can install the binary from SourceForge, but the fact that it is a binary from SourceForge is making me a little queasy 😝. Especially since it is being used to build installers. Getting it to build from source would make me feel way more comfortable. Any help would be appreciated.

@jakirkham
Copy link
Member

Could you please take a look at issue ( conda-forge/conda-feedstock#1 ) when you have a chance, @msarahan? Seems like the activation scripts are getting messed up in the conda package. Have gone ahead and pulled these until we solve the issue, but the packages can still be inspected if you wish to look at them.

@jakirkham
Copy link
Member

Could you please provide some thoughts on PR ( #1205 ), @msarahan? The OP is working on a tool that allows one to call commands from a conda environment without having to explicitly activate first by having a wrapper that does this for you. There are variants for other things like virtualenv. It would be really neat to figure out how to get this to work best with conda.

@jakirkham
Copy link
Member

Could you please take a look at issue ( conda-forge/openssl-feedstock#3 ), @msarahan? We are totally mystified. It seems that there is some openssl package that has a post-link step going wrong. Though we are pretty sure it isn't ours (despite what the log says) as we don't have a post-link step. Our best guess is it is coming from defaults. Though I'm also having a bit of trouble tracking down with openssl package it is.

@jakirkham
Copy link
Member

Could you please take a look at PR ( #1144 ), @msarahan? We think this is an ok strategy, but would like feedback.

@jakirkham
Copy link
Member

Would appreciate your thoughts on PR ( #1491 ), @msarahan. Especially as there appears to be a defaults package for it yet there appears not to be a recipe in the open.

@jakirkham
Copy link
Member

jakirkham commented Sep 7, 2016

This error is pretty weird. It appears FWICT that conda-build messed up at packaging Python 2.7 and 3.5 builds for Windows 32-bit (they only have the info directory and not Lib). Would love to understand why that went wrong.

cc @msarahan @pmlandwehr

@jakirkham
Copy link
Member

Could you please take a look at PR ( #1491 ) for libevent, @msarahan? I think this is different than defaults in some ways (though can't check as there is no open source recipe for it AFAICT).

@jakirkham
Copy link
Member

Could you please take a look at PR ( #1678 ), @msarahan and @pelson ? This a continuation of PR ( #617 ), which adds support for VS 2008 64-bit to AppVeyor. We think it is ready to go, but it would be nice if the two of you could give it a quick look through.

@jakirkham
Copy link
Member

Think the story for directing and notifying about issues has gotten a bit better over the years. Partially by increasing reviewer bandwidth. Partially by adding reviewer teams. Partially by people reaching out on Gitter about things that are blocked periodically. Going to close this out. Feel free to reopen if there is something here that still needs to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

7 participants