add Nbval package #2750
add Nbval package #2750
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
| sha256: {{ sha256 }} | ||
|
|
||
| build: | ||
| number: 0 |
There was a problem hiding this comment.
does noarch work reliable yet?
There was a problem hiding this comment.
I don't think noarch uploads work yet on the conda-forge setups.
There was a problem hiding this comment.
Yeah, not yet. We need to migrate to conda 4.3 and make some changes to conda-smithy, but it should be doable.
|
@takluyver is ok being a maintainer see here |
|
|
||
| build: | ||
| number: 0 | ||
| script: python setup.py install --single-version-externally-managed --record record.txt |
There was a problem hiding this comment.
We often do our recipes with pip install --no-deps . - is there an advantage to this command?
There was a problem hiding this comment.
I'm not sure there is much difference between the two. I've just used the default value in the example script.
There was a problem hiding this comment.
There is a discussion about this topic as well
There was a problem hiding this comment.
We have become a lot more relaxed about this since that issue was opened. Feel free to pick one of those two and go with it.
|
@takluyver Is this OK for you and can be merged? |
|
No complaints from me. |
No description provided.