Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Nbval package #2750

Merged
merged 3 commits into from
Apr 8, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions recipes/nbval/LICENSE
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
A py.test plugin for validating IPython notebooks

License applies to all source code, and binaries generated from the
source code, found at
https://github.com/computationalmodelling/pytest_validate_nb

------------------------------------------------------------
Copyright (C) 2014 Oliver W. Laslett <O.Laslett@soton.ac.uk>
David Cortes-Ortuno
Maximilian Albert
Ondrej Hovorka
Hans Fangohr
(University of Southampton, UK)


All rights reserved.

Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
met:

Redistributions of source code must retain the above copyright notice,
this list of conditions and the following disclaimer.

Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.

Neither the names of the contributors nor the associated institutions
may be used to endorse or promote products derived from this software
without specific prior written permission.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

44 changes: 44 additions & 0 deletions recipes/nbval/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
{% set name = "nbval" %}
{% set version = "0.5" %}
{% set sha256 = "bd245c0fb3ade4aff63948d31de5cb5f92129c7387e597d1229f687e5350eba7" %}

package:
name: {{ name|lower }}
version: {{ version }}

source:
fn: {{ name }}-{{ version }}.tar.gz
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz
sha256: {{ sha256 }}

build:
number: 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add noarch: python ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does noarch work reliable yet?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think noarch uploads work yet on the conda-forge setups.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not yet. We need to migrate to conda 4.3 and make some changes to conda-smithy, but it should be doable.

script: python setup.py install --single-version-externally-managed --record record.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We often do our recipes with pip install --no-deps . - is there an advantage to this command?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure there is much difference between the two. I've just used the default value in the example script.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a discussion about this topic as well

#528

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have become a lot more relaxed about this since that issue was opened. Feel free to pick one of those two and go with it.


requirements:
build:
- python
- setuptools
run:
- python
- pytest
- six
- nbformat
- ipykernel
- jupyter_client

test:
imports:
- nbval

about:
home: https://github.com/computationalmodelling/nbval
license: BSD-3-Clause
license_family: BSD
license_file: '{{ environ["RECIPE_DIR"] }}/LICENSE'
summary: 'A py.test plugin to validate Jupyter notebooks'

extra:
recipe-maintainers:
- kain88-de
- takluyver