Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple compatibility issues with conda build 1.x #68

Merged
merged 1 commit into from
Dec 16, 2016

Conversation

mwcraig
Copy link
Contributor

@mwcraig mwcraig commented Nov 3, 2016

As discussed in #60, there were a couple of lines that are not compatible with conda build 1.x. This should fix those...

@pelson pelson merged commit b70616e into conda-tools:master Dec 16, 2016
@ocefpaf
Copy link
Member

ocefpaf commented Dec 16, 2016

Thanks @mwcraig for the PR and @pelson for merging.

BTW this is no longer a conda-build 1 workaround because this behavior is back in latest conda-build 2. So the previous behavior, that used the extra config argument, is the one deprecated.

PS: Can we get a new release 😉

@mwcraig
Copy link
Contributor Author

mwcraig commented Dec 16, 2016

@Ocepaf - I think the change needed for t latest conda-build is a little different than that. The call being made now is not part of t API and should not be used. There is an API now for getting the path to the built package. Will get to that PR on Monday unless someone else does it sooner.

@ocefpaf
Copy link
Member

ocefpaf commented Dec 16, 2016

There is an API now for getting the path to the built package.

Nice. I thought there was not one when I tried #70

@mwcraig
Copy link
Contributor Author

mwcraig commented Dec 16, 2016

See this if you want to fix today 😉: astropy/conda-channel-astropy#105 (comment)

I'd wait for that fix before a new release that we know will be broken with the latest conda build.

@ocefpaf
Copy link
Member

ocefpaf commented Dec 16, 2016

Thanks @mwcraig. I can wait. (I had it pinned before to get the packages uploaded but now I actually want the get latest conda-build in my repo.)

Cool! did not know about get_output_file_path.

@mwcraig
Copy link
Contributor Author

mwcraig commented Dec 16, 2016

Neither did I...still not used to the idea that there is an API that should be used instead of reading the source code!

@@ -39,7 +39,10 @@ def build(meta, test=True):

def upload(cli, meta, owner, channels=['main'], config=None):
"""Upload a distribution, given the build metadata."""
fname = bldpkg_path(meta, config)
if hasattr(conda_build, 'api'):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out this does not work as a fix for conda-build 2 too because conda-build does have the api 😒

I am preparing another PR... Let's see.

@jakirkham
Copy link
Member

jakirkham commented Dec 30, 2016

So this seems to cause some weird issues when trying to build things using numpy. Not entirely sure why, but going back to 1.0.0 does not encounter these issues.

xref: #75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants