Moved key serialization to a JSON serializer. #33
Conversation
…g as well as schema keys. Added uinit tests for testing ordering and key serialization
|
@junrao Ready for you to review. Take a look at unit tests to understand the ordering between top-level config key, subject-level config key and schema key |
| @@ -0,0 +1,21 @@ | |||
| /* | |||
There was a problem hiding this comment.
Please ignore this file. I will delete it during the merge.
| return compare; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
We need to be able to compare all combinations of different types of SchemaRegistryKey. Instead of duplicating the code, perhaps we can write all comparators in a dispatcher in SchemaRegistryKey once and just call the dispatcher in the compareTo() implementation of each type.
Perhaps we need to do the same for equals().
There was a problem hiding this comment.
That seems counter intuitive. Both classes extend from SchemaRegistryKey. If 2 keys of different sub classes are being compared, they will be sorted based on keyType anyway. There is no duplication. Each sub class only compares according to it's own class members.
Same for equals
|
@junrao Addressed all your review comments. I'd like to merge this to allow sending a pull request for making PUT/GET /config work. I will go ahead and do that if you don't have further review comments |
|
@junrao As discussed offline, I will include the json property ordering and the serialization into a map change in my new pull request. |
Added support for config as well as schema keys. Added unit tests for testing ordering and key serialization. Fixes #15