Moved key serialization to a JSON serializer. #33
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| /* | ||
| * Copyright 2014 Confluent Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package io.confluent.kafka.schemaregistry.storage; | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
|
|
||
| public class ConfigKey extends SchemaRegistryKey { | ||
|
|
||
| private static final int MAGIC_BYTE = 0; | ||
| private String subject; | ||
|
|
||
| public ConfigKey(@JsonProperty("subject") String subject) { | ||
| super(SchemaRegistryKeyType.CONFIG); | ||
| this.subject = subject; | ||
| this.magicByte = MAGIC_BYTE; | ||
| } | ||
|
|
||
| @JsonProperty("subject") | ||
| public String getSubject() { | ||
| return this.subject; | ||
| } | ||
|
|
||
| @JsonProperty("subject") | ||
| public void setSubject(String subject) { | ||
| this.subject = subject; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) { | ||
| return true; | ||
| } | ||
| if (o == null || getClass() != o.getClass()) { | ||
| return false; | ||
| } | ||
|
|
||
| ConfigKey that = (ConfigKey) o; | ||
|
|
||
| if (!super.equals(o)) { | ||
| return false; | ||
| } | ||
| if (this.subject != null && that.subject != null) { | ||
| if (!subject.equals(that.subject)) { | ||
| return false; | ||
| } | ||
| } else if (this.subject == null && that.subject == null) { | ||
| return true; | ||
| } else { | ||
| return false; | ||
| } | ||
| return true; | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| int result = super.hashCode(); | ||
| if (this.subject != null) { | ||
| result = 31 * result + subject.hashCode(); | ||
| } | ||
| return result; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| StringBuilder sb = new StringBuilder(); | ||
| sb.append("{magic=" + this.magicByte + ","); | ||
| sb.append("keytype=" + this.keyType.keyType + ","); | ||
| sb.append("subject=" + this.subject + "}"); | ||
| return sb.toString(); | ||
| } | ||
|
|
||
| @Override | ||
| public int compareTo(SchemaRegistryKey o) { | ||
| int compare = super.compareTo(o); | ||
| if (compare == 0) { | ||
| ConfigKey otherKey = (ConfigKey) o; | ||
| if (this.subject == null && otherKey.subject == null) { | ||
| return 0; | ||
| } else { | ||
| if (this.subject == null) { | ||
| return -1; | ||
| } | ||
| if (otherKey.subject == null) { | ||
| return 1; | ||
| } | ||
| return this.subject.compareTo(otherKey.subject); | ||
| } | ||
| } else { | ||
| return compare; | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to be able to compare all combinations of different types of SchemaRegistryKey. Instead of duplicating the code, perhaps we can write all comparators in a dispatcher in SchemaRegistryKey once and just call the dispatcher in the compareTo() implementation of each type.
Perhaps we need to do the same for equals().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems counter intuitive. Both classes extend from SchemaRegistryKey. If 2 keys of different sub classes are being compared, they will be sorted based on keyType anyway. There is no duplication. Each sub class only compares according to it's own class members.
Same for equals