Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integ 231 improve error handling within analytics app component #2919

Merged
merged 21 commits into from
Mar 28, 2023
Merged

Integ 231 improve error handling within analytics app component #2919

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
353d94b
Fix overflow of error messages in Note component
lilbitner Mar 24, 2023
1b7ecf2
Adjust empty data message
lilbitner Mar 24, 2023
0883770
Add HyperLink component with tests
lilbitner Mar 24, 2023
aaca129
Adjust tests in SlugWarningDisplay component
lilbitner Mar 24, 2023
f685223
Add ErrorDisplay component and adjust error types
lilbitner Mar 24, 2023
30b7780
Lint fixes
lilbitner Mar 24, 2023
7f5c307
Remove console
lilbitner Mar 24, 2023
0fbe7a3
Some copy changes
lilbitner Mar 24, 2023
d3dde60
Add spec to ErrorDisplay
lilbitner Mar 24, 2023
5d95808
Fix linter
lilbitner Mar 24, 2023
3df77d2
Fix typing of HyperLink component
lilbitner Mar 27, 2023
10e300c
Small semantic changes
lilbitner Mar 27, 2023
c7a1611
Cleaned-up variables declarations
lilbitner Mar 27, 2023
43e0bc8
Handle errors other than explicit API types and fix width of note banner
lilbitner Mar 27, 2023
6fab9c9
Change variable name
lilbitner Mar 27, 2023
c77cac8
Update copies
lilbitner Mar 27, 2023
8b83d45
adjust copies and add hyperlinks to contact support
lilbitner Mar 27, 2023
1fbc09b
Refactor to avoid JSX elements in state as per PR review
lilbitner Mar 28, 2023
9c7fefc
Add handling for other errors
lilbitner Mar 28, 2023
0fd8b3a
Remove console.error
lilbitner Mar 28, 2023
94d1dcc
Set error to null when successfully retreiving data
lilbitner Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust empty data message
  • Loading branch information
@lilbitner
lilbitner committed Mar 28, 2023
commit 1b7ecf2ad2b6f9ece7c04a405d9fa469991c71cd
3 changes: 2 additions & 1 deletion apps/google-analytics-4/frontend/src/components/main-app/constants/noteMessages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
export const DEFAULT_ERR_MSG = 'Oops! Cannot display the analytics data at this time.';
export const EMPTY_DATA_MSG = 'There are no page views to show for this range.';
export const EMPTY_DATA_MSG =
lilbitner marked this conversation as resolved.
Show resolved Hide resolved
'There are no page views to show for this range. If this is not expected, assure your URL prefix and slug value accurately reflect a page path within your Google Analytics instance.';
export const DEFAULT_CONTENT_MSG = 'Oops! Something went wrong with the slug field configuration.';

export const getContentTypeSpecificMsg = (contentTypeName: string, isHyperlink?: boolean) => ({
Expand Down