New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integ 231 improve error handling within analytics app component #2919

Merged

lilbitner merged 21 commits into master from INTEG-231-Improve-error-handling-within-AnalyticsApp-component

Mar 28, 2023

Fix linter

Loading branch information

lilbitner committed Mar 28, 2023

commit 5d9580870fad241fc181accca4463a186d1bf546

apps/google-analytics-4/frontend/src/components/main-app/ErrorDisplay/ErrorDisplay.tsx

-Original file line number
+Diff line change
@@ Expand Up / @@ -44,7 +44,7 @@ const ErrorDisplay = (props: Props) => { @@
         else {
           setErrorMessage(error.message || DEFAULT_ERR_MSG);
         }
-      }, [error]);
+      }, [error, sdk.navigator]);
       return <Note body={errorMessage} variant="negative" />;
     };
@@ Expand Down @@