Chore: Update Thanos #6189
Merged
Chore: Update Thanos #6189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the data race relevant to this change? Looks a bit concerning |
harry671003
force-pushed
the
update_thanos
branch
from
6f20452
to
15808c3
Compare
harry671003
force-pushed
the
update_thanos
branch
2 times, most recently
from
e70c9c5
to
f5e8961
Compare
|
@yeya24 - The data race seems to have gone away in the latest change. |
yeya24
reviewed
Sep 4, 2024
pkg/ruler/user2/namespace
Outdated
There was a problem hiding this comment.
Those files are used for testing only and should be excluded.
There was a problem hiding this comment.
Removed the files from this PR.
Fixing this permanently: #6193
| "cortex_compactor_block_cleanup_started_total", | ||
| "cortex_compactor_block_cleanup_completed_total", | ||
| "cortex_compactor_block_cleanup_failed_total", |
There was a problem hiding this comment.
Why those metrics are removed?
There was a problem hiding this comment.
This metric names list is only used for choosing which metric names to compare. Previously, testutil.GatherAndCompare() was very lenient. If a metric name was not present in the list, it'll ignore it. But now, it'll fail with expected metric name(s) not found.
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
harry671003
force-pushed
the
update_thanos
branch
from
f5e8961
to
75d13b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
09db52562de0984d097554387274a654db19ce83Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]