Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use temp dir for ruler LoadPartialGroups test #6193

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Use temp dir for ruler LoadPartialGroups test #6193

merged 1 commit into from
Sep 4, 2024

Conversation

harry671003
Copy link
Contributor

What this PR does:

  • This one test was not using the temp dir for storing rules.
  • The following files were always created when running tests locally:
    • pkg/ruler/user2/namespace
    • pkg/ruler/user3/namespace

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@harry671003
Use temp dir for ruler LoadPartialGroups test
ce1c7e5 
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
@harry671003 harry671003 mentioned this pull request Sep 4, 2024
Merged
3 tasks
yeya24
yeya24 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yeya24 yeya24 merged commit d8a7636 into cortexproject:master Sep 4, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeya24 yeya24 yeya24 approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harry671003 @yeya24