Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Don't break SignModeHandler API #14087

Merged
merged 10 commits into from
Dec 1, 2022
Merged

refactor: Don't break SignModeHandler API #14087

merged 10 commits into from
Dec 1, 2022

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented Nov 30, 2022 •
edited
Loading

Description

This PR reverts the API breaking changes on SignModeHandler introduced in #13701, as they break rosetta integration. It does so by introducing a new SignModeHandlerWithContext interface, and let consumers type cast to check which interface to use.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added C:CLI C:Rosetta Issues and PR related to Rosetta C:x/auth labels Nov 30, 2022
@amaury1093 amaury1093 marked this pull request as ready for review November 30, 2022 10:02
@amaury1093 amaury1093 requested a review from a team as a code owner November 30, 2022 10:02
alexanderbez
alexanderbez approved these changes Nov 30, 2022
View reviewed changes
client/tx/tx.go Outdated Show resolved Hide resolved
aaronc
aaronc reviewed Nov 30, 2022
View reviewed changes
client/tx/tx.go Outdated Show resolved Hide resolved
@amaury1093
Copy link
Contributor Author

R4R again. I addressed you rcomments @aaronc and @julienrbrt

@julienrbrt
Copy link
Member

R4R again. I addressed you rcomments @aaronc and @julienrbrt

Seems like some tests are still failing.

@julienrbrt julienrbrt mentioned this pull request Dec 1, 2022
Merged
19 tasks
@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2022

[Cosmos SDK - SimApp] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2022

[Cosmos SDK - Rosetta] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2022

[Cosmos SDK] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

63.6% 63.6% Coverage
0.0% 0.0% Duplication

@julienrbrt julienrbrt merged commit fb4d964 into main Dec 1, 2022
@julienrbrt julienrbrt deleted the am/smh-new-interface branch December 1, 2022 15:20
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@amaury1093
refactor: don't break SignModeHandler API (cosmos#14087)
c756ebb 
* refactor: Make SignModeHandler update not API breaking

* changelog

* fix tests

* add comment

* Revert rosetta

* address reviews

* shorter name

* Fix test build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronc aaronc aaronc left review comments

@alexanderbez alexanderbez alexanderbez approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

Assignees
No one assigned
Labels
C:CLI C:Rosetta Issues and PR related to Rosetta C:x/auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amaury1093 @julienrbrt @aaronc @alexanderbez