Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Don't break SignModeHandler API #14087

Merged
merged 10 commits into from
Dec 1, 2022
Merged

refactor: Don't break SignModeHandler API #14087

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
38329a6
refactor: Make SignModeHandler update not API breaking
amaury1093 Nov 30, 2022
f50232c
changelog
amaury1093 Nov 30, 2022
6abda75
fix tests
amaury1093 Nov 30, 2022
39e0f6c
add comment
amaury1093 Nov 30, 2022
6f2e78a
Merge branch 'main' into am/smh-new-interface
amaury1093 Nov 30, 2022
6433fb5
Revert rosetta
amaury1093 Nov 30, 2022
a1e5c9f
address reviews
amaury1093 Dec 1, 2022
75fd8c9
shorter name
amaury1093 Dec 1, 2022
e0b9bd2
Merge branch 'main' of ssh://github.com/cosmos/cosmos-sdk into am/smh…
amaury1093 Dec 1, 2022
40a256f
Fix test build
amaury1093 Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix test build
  • Loading branch information
@amaury1093
amaury1093 committed Dec 1, 2022
commit 40a256f9b9486ce8290321cb63274d76c7674643
2 changes: 1 addition & 1 deletion x/auth/ante/feegrant_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ func genTxWithFeeGranter(gen client.TxConfig, msgs []sdk.Msg, feeAmt sdk.Coins,
AccountNumber: accNums[i],
Sequence: accSeqs[i],
}
signBytes, err := gen.SignModeHandler().GetSignBytes(nil, signMode, signerData, tx.GetTx())
signBytes, err := gen.SignModeHandler().GetSignBytes(signMode, signerData, tx.GetTx())
if err != nil {
panic(err)
}
Expand Down
6 changes: 3 additions & 3 deletions x/auth/signing/handler_map_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,16 +66,16 @@ func TestHandlerMap_GetSignBytes(t *testing.T) {
Sequence: seqNum,
PubKey: priv1.PubKey(),
}
signBz, err := handler.GetSignBytes(nil, signingtypes.SignMode_SIGN_MODE_LEGACY_AMINO_JSON, signingData, tx)
signBz, err := handler.GetSignBytes(signingtypes.SignMode_SIGN_MODE_LEGACY_AMINO_JSON, signingData, tx)
require.NoError(t, err)

expectedSignBz, err := aminoJSONHandler.GetSignBytes(nil, signingtypes.SignMode_SIGN_MODE_LEGACY_AMINO_JSON, signingData, tx)
expectedSignBz, err := aminoJSONHandler.GetSignBytes(signingtypes.SignMode_SIGN_MODE_LEGACY_AMINO_JSON, signingData, tx)
require.NoError(t, err)

require.Equal(t, expectedSignBz, signBz)

// expect error with wrong sign mode
_, err = aminoJSONHandler.GetSignBytes(nil, signingtypes.SignMode_SIGN_MODE_DIRECT, signingData, tx)
_, err = aminoJSONHandler.GetSignBytes(signingtypes.SignMode_SIGN_MODE_DIRECT, signingData, tx)
require.Error(t, err)
}

Expand Down
2 changes: 1 addition & 1 deletion x/auth/tx/aux_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ func TestBuilderWithAux(t *testing.T) {
Sequence: 15,
})
signBz, err = txConfig.SignModeHandler().GetSignBytes(
nil, signing.SignMode_SIGN_MODE_DIRECT,
signing.SignMode_SIGN_MODE_DIRECT,
authsigning.SignerData{
Address: feepayerAddr.String(),
ChainID: chainID,
Expand Down