Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Change --gas=0 semantic and introduce --gas=simulate #2306

Merged
merged 6 commits into from
Sep 12, 2018
Merged

R4R: Change --gas=0 semantic and introduce --gas=simulate #2306

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ceba51a
Change --gas=0 semantic and introduce --gas=simulate
Sep 11, 2018
40cd51e
Add test cases with gas=0
Sep 11, 2018
4222b9d
ACK suggestion from @alexanderbez
Sep 11, 2018
7f15866
s/GasFlagSimulateString/GasFlagSimulate/
Sep 11, 2018
461261a
Drop TODO comment on Gas type
Sep 11, 2018
cb05261
Enrich TODO with ref
Sep 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test cases with gas=0
  • Loading branch information
Alessio Treglia committed Sep 11, 2018
commit 40cd51e17a0f13b351a2de09f6eeddace4048205
6 changes: 5 additions & 1 deletion client/lcd/lcd_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,10 +270,14 @@ func TestCoinSend(t *testing.T) {
res, body, _ = doSendWithGas(t, port, seed, name, password, addr, "100", 0, "")
require.Equal(t, http.StatusInternalServerError, res.StatusCode, body)

// test failure with too negative gas
// test failure with negative gas
res, body, _ = doSendWithGas(t, port, seed, name, password, addr, "-200", 0, "")
alessio marked this conversation as resolved.
Show resolved Hide resolved
require.Equal(t, http.StatusInternalServerError, res.StatusCode, body)
alessio marked this conversation as resolved.
Show resolved Hide resolved

// test failure with 0 gas
res, body, _ = doSendWithGas(t, port, seed, name, password, addr, "0", 0, "")
require.Equal(t, http.StatusInternalServerError, res.StatusCode, body)

// test failure with wrong adjustment
res, body, _ = doSendWithGas(t, port, seed, name, password, addr, "simulate", 0.1, "")
require.Equal(t, http.StatusInternalServerError, res.StatusCode, body)
Expand Down
4 changes: 4 additions & 0 deletions cmd/gaia/cli_test/cli_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,10 @@ func TestGaiaCLIGasAuto(t *testing.T) {
success = executeWrite(t, fmt.Sprintf("gaiacli send %v --gas=-100 --amount=10steak --to=%s --from=foo", flags, barAddr), app.DefaultKeyPass)
alessio marked this conversation as resolved.
Show resolved Hide resolved
require.False(t, success)

// Test failure with 0 gas
success = executeWrite(t, fmt.Sprintf("gaiacli send %v --gas=0 --amount=10steak --to=%s --from=foo", flags, barAddr), app.DefaultKeyPass)
require.False(t, success)

// Enable auto gas
success, stdout, _ := executeWriteRetStdStreams(t, fmt.Sprintf("gaiacli send %v --json --gas=simulate --amount=10steak --to=%s --from=foo", flags, barAddr), app.DefaultKeyPass)
require.True(t, success)
Expand Down