Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Change --gas=0 semantic and introduce --gas=simulate #2306

Merged
merged 6 commits into from
Sep 12, 2018
Merged

R4R: Change --gas=0 semantic and introduce --gas=simulate #2306

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ceba51a
Change --gas=0 semantic and introduce --gas=simulate
Sep 11, 2018
40cd51e
Add test cases with gas=0
Sep 11, 2018
4222b9d
ACK suggestion from @alexanderbez
Sep 11, 2018
7f15866
s/GasFlagSimulateString/GasFlagSimulate/
Sep 11, 2018
461261a
Drop TODO comment on Gas type
Sep 11, 2018
cb05261
Enrich TODO with ref
Sep 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Enrich TODO with ref
  • Loading branch information
Alessio Treglia committed Sep 11, 2018
commit cb0526177adf5af14d6ca39ccc93b0a0cd899b7c
2 changes: 1 addition & 1 deletion x/auth/client/txbuilder/txbuilder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ type TxBuilder struct {
Codec *wire.Codec
AccountNumber int64
Sequence int64
Gas int64 // TODO: should this turn into uint64? requires further discussion
Gas int64 // TODO: should this turn into uint64? requires further discussion - see #2173
alessio marked this conversation as resolved.
Show resolved Hide resolved
GasAdjustment float64
SimulateGas bool
ChainID string
Expand Down