Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended permissions for module accounts #4679

Merged
merged 16 commits into from
Jul 6, 2019
Merged

Extended permissions for module accounts #4679

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
31d901f
extended permissions for module accounts
colin-axner Jul 3, 2019
cef1308
updated docs and added pending log
colin-axner Jul 3, 2019
d4eeeda
address some of @fedekunze pr comments, move permaddr to types/
colin-axner Jul 3, 2019
bdf58f3
add staking permission
colin-axner Jul 3, 2019
198313d
Update x/supply/internal/keeper/bank.go
alexanderbez Jul 5, 2019
5738e88
Update x/supply/internal/keeper/bank.go
alexanderbez Jul 5, 2019
87eff5c
Update x/supply/internal/keeper/bank.go
alexanderbez Jul 5, 2019
1316e2f
Update x/supply/internal/keeper/bank.go
alexanderbez Jul 5, 2019
e8827dd
address pr review comments
colin-axner Jul 5, 2019
92dfa90
Merge branch 'colin/4652-extend-supply-permissions' of github.com:cos…
colin-axner Jul 5, 2019
5d15a4c
merge conflicts
colin-axner Jul 5, 2019
0772d29
Update x/supply/internal/keeper/bank.go
alexanderbez Jul 6, 2019
e22f70c
Apply suggestions from code review
fedekunze Jul 6, 2019
d36686b
apply @fedekunze review suggestions
colin-axner Jul 6, 2019
fb901fd
fix merge conflicts
colin-axner Jul 6, 2019
e513d24
fix spelling
colin-axner Jul 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
  • Loading branch information
@fedekunze
fedekunze committed Jul 6, 2019
commit e22f70c958b15377f976c93c4366b74d65d71dde
2 changes: 1 addition & 1 deletion x/auth/test_common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func (ma moduleAccount) GetName() string {
return ma.name
}

// GetPermissions returns permissions granted to the module account (holder/minter/burner)
// GetPermissions returns permissions granted to the module account
func (ma moduleAccount) GetPermissions() []string {
return ma.permissions
}
Expand Down
4 changes: 2 additions & 2 deletions x/mint/internal/keeper/test_common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ func newTestInput(t *testing.T) testInput {
maccPerms := map[string][]string{
auth.FeeCollectorName: []string{supply.Basic},
types.ModuleName: []string{supply.Minter},
staking.NotBondedPoolName: []string{supply.Burner},
staking.BondedPoolName: []string{supply.Burner},
staking.NotBondedPoolName: []string{supply.Burner, supply.Staking},
staking.BondedPoolName: []string{supply.Burner, supply.Staking},
}
supplyKeeper := supply.NewKeeper(types.ModuleCdc, keySupply, accountKeeper, bankKeeper, supply.DefaultCodespace, maccPerms)
supplyKeeper.SetSupply(ctx, supply.NewSupply(sdk.Coins{}))
Expand Down