Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended permissions for module accounts #4679

Merged
merged 16 commits into from
Jul 6, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix merge conflicts
  • Loading branch information
colin-axner committed Jul 6, 2019
commit fb901fd4c4e66f8556df3520ab0c88ad0a189596
4 changes: 2 additions & 2 deletions x/auth/test_common.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ type testInput struct {
// moduleAccount defines an account for modules that holds coins on a pool
type moduleAccount struct {
*types.BaseAccount
name string `json:"name"` // name of the module
permissions []string `json:"permissions"` // permissions of module account (minter/burner/holder)
name string `json:"name" yaml:"name"` // name of the module
permissions []string `json:"permissions" yaml"permissions"` // permissions of module account
}

// HasPermission returns whether or not the module account has permission.
Expand Down
4 changes: 2 additions & 2 deletions x/genaccounts/genesis_account.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ type GenesisAccount struct {
EndTime int64 `json:"end_time" yaml:"end_time"` // vesting end time (UNIX Epoch time)

// module account fields
ModuleName string `json:"module_name"` // name of the module account
ModulePermissions []string `json:"module_permissions"` // permissions of module account
ModuleName string `json:"module_name" yaml:"module_name"` // name of the module account
ModulePermissions []string `json:"module_permissions" yaml:"module_permissions"` // permissions of module account
}

// Validate checks for errors on the vesting and module account parameters
Expand Down
4 changes: 2 additions & 2 deletions x/supply/internal/types/account.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ var _ exported.ModuleAccountI = (*ModuleAccount)(nil)
// ModuleAccount defines an account for modules that holds coins on a pool
type ModuleAccount struct {
*authtypes.BaseAccount
Name string `json:"name"` // name of the module
Permissions []string `json:"permissions"` // permissions of module account
Name string `json:"name" yaml:"name"` // name of the module
Permissions []string `json:"permissions" yaml:"permissions"` // permissions of module account
}

// NewModuleAddress creates an AccAddress from the hash of the module's name
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.