Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert change of StdSignature PubKey to []byte #6885

Merged
merged 4 commits into from
Jul 30, 2020

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jul 29, 2020

In #5795, StdSignature.PubKey was change from crypto.PubKey to []byte. This was supposed to be a temporary workaround for protobuf migration. It breaks legacy clients and should be reverted.

In a separate PR we will also need to revert #5682 and find an alternate solution.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@aaronc aaronc marked this pull request as ready for review July 29, 2020 20:02
@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #6885 into master will decrease coverage by 2.27%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master    #6885      +/-   ##
==========================================
- Coverage   60.83%   58.56%   -2.28%     
==========================================
  Files         380      356      -24     
  Lines       24832    21324    -3508     
==========================================
- Hits        15107    12488    -2619     
+ Misses       8568     7852     -716     
+ Partials     1157      984     -173     

@aaronc aaronc added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 29, 2020
@aaronc aaronc added A:automerge Automatically merge PR once all prerequisites pass. and removed A:automerge Automatically merge PR once all prerequisites pass. labels Jul 30, 2020
@mergify mergify bot merged commit ef6dc2f into master Jul 30, 2020
@mergify mergify bot deleted the aaronc/revert-std-signature-changes branch July 30, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants