Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert change of StdSignature PubKey to []byte #6885

Merged
merged 4 commits into from
Jul 30, 2020
Merged

Revert change of StdSignature PubKey to []byte #6885

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b5b1ff
Revert change of StdSignature.PubKey to []byte
aaronc Jul 29, 2020
c1f66a6
Merge branch 'master' into aaronc/revert-std-signature-changes
aaronc Jul 29, 2020
76d324d
Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into aa…
aaronc Jul 30, 2020
da8176f
Fixes
aaronc Jul 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixes
  • Loading branch information
@aaronc
aaronc committed Jul 30, 2020
commit da8176ff2cd2c9f22ddcbc07a74a2f50fb5fea47
9 changes: 1 addition & 8 deletions x/auth/types/stdtx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,13 +387,6 @@ func StdSignatureToSignatureV2(cdc *codec.Codec, sig StdSignature) (signing.Sign

// SignatureV2ToStdSignature converts a SignatureV2 to a StdSignature
func SignatureV2ToStdSignature(cdc *codec.Codec, sig signing.SignatureV2) (StdSignature, error) {
var pubKeyBz []byte

pubKey := sig.PubKey
if pubKey != nil {
pubKeyBz = pubKey.Bytes()
}

var (
sigBz []byte
err error
Expand All @@ -407,7 +400,7 @@ func SignatureV2ToStdSignature(cdc *codec.Codec, sig signing.SignatureV2) (StdSi
}

return StdSignature{
PubKey: pubKeyBz,
PubKey: sig.PubKey,
Signature: sigBz,
}, nil
}
Expand Down