Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump borsh to v1 #1245

Merged
merged 7 commits into from
May 31, 2024
Merged

Bump borsh to v1 #1245

merged 7 commits into from
May 31, 2024

Conversation

seanchen1991
Copy link
Contributor

Closes: #1244

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@seanchen1991 seanchen1991 requested a review from rnbguy May 30, 2024 17:49
@codecov Codecov
Copy link

codecov bot commented May 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.41176% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 65.52%. Comparing base (dcf8c36) to head (1b3aed9).

Files Patch % Lines
ibc-core/ics03-connection/types/src/connection.rs 0.00% 3 Missing ⚠️
ibc-apps/ics20-transfer/types/src/amount.rs 60.00% 2 Missing ⚠️
ibc-core/ics04-channel/types/src/channel.rs 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1245      +/-   ##
==========================================
- Coverage   65.56%   65.52%   -0.05%     
==========================================
  Files         234      234              
  Lines       23519    23476      -43     
==========================================
- Hits        15421    15383      -38     
+ Misses       8098     8093       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnbguy
Copy link
Collaborator

rnbguy commented May 31, 2024

Thanks for taking care of this, Sean! Can you open an PR on basecoin side to test this update?

rnbguy
rnbguy approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Sean ! 🙌🏽

@seanchen1991 seanchen1991 added this pull request to the merge queue May 31, 2024
Merged via the queue into main with commit 5779e86 May 31, 2024
19 checks passed
@seanchen1991 seanchen1991 deleted the chore/bump-borsh branch May 31, 2024 18:35
rnbguy added a commit that referenced this pull request Jun 7, 2024
@rnbguy
Revert "Bump borsh to v1 (#1245)"
b4c1f9b 
This reverts commit 5779e86.
rnbguy added a commit that referenced this pull request Jun 7, 2024
@rnbguy
Revert "Bump borsh to v1 (#1245)"
6504e59 
This reverts commit 5779e86.
rnbguy added a commit that referenced this pull request Jun 7, 2024
@rnbguy
Revert "Bump borsh to v1 (#1245)"
3b48933 
This reverts commit 5779e86.
rnbguy added a commit that referenced this pull request Jun 8, 2024
@rnbguy
Revert "Bump borsh to v1 (#1245)"
341af14 
This reverts commit 5779e86.
rnbguy added a commit that referenced this pull request Jun 12, 2024
@rnbguy
Revert "Bump borsh to v1 (#1245)"
7df27af 
This reverts commit 5779e86.
rnbguy added a commit that referenced this pull request Jun 13, 2024
@rnbguy
Revert "Bump borsh to v1 (#1245)"
ee4a9c3 
This reverts commit 5779e86.
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
@seanchen1991
Bump borsh to v1 (#1245)
92899f2 
* Remove `borsh::maybestd`

* Add #[borsh(use_discriminant)] attributes

* Undo toml formatting

* Update cw-check Cargo.lock

* Fix clippy warnings

* Switch to using borsh::from_slice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnbguy rnbguy rnbguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update borsh dependency to v1
2 participants
@seanchen1991 @rnbguy