Switch to using borsh::from_slice

ibc-apps/ics20-transfer/types/src/amount.rs

@@ -48,8 +48,8 @@
         let mut buf = [0; 32];
         let bytes_read = reader.read(&mut buf)?;
         if bytes_read != 32 {
             return Err(borsh::io::Error::new(
                 borsh::io::ErrorKind::InvalidInput,
                 format!("Expected to read 32 bytes, read {bytes_read}"),
             ));
         }
@@ -145,15 +145,13 @@
     #[cfg(feature = "borsh")]
     #[test]
     fn borsh_amount() {
-        use borsh::BorshDeserialize;
-
         let value = Amount::from(42);
         let serialized = borsh::to_vec(&value).unwrap();
 
         // Amount is supposed to be a U256 according to the spec, which is 32 bytes
         assert_eq!(serialized.len(), 32);
 
-        let value_deserialized = Amount::try_from_slice(&serialized).unwrap();
+        let value_deserialized = borsh::from_slice::<Amount>(&serialized).unwrap();
 
         assert_eq!(value, value_deserialized);
     }

ibc-apps/ics721-nft-transfer/types/src/class.rs

@@ -442,10 +442,8 @@ mod tests {
     #[test]
     fn test_borsh_roundtrip() {
         fn borsh_roundtrip(class_uri: ClassUri) {
-            use borsh::BorshDeserialize;
-
             let class_uri_bytes = borsh::to_vec(&class_uri).unwrap();
-            let res = ClassUri::try_from_slice(&class_uri_bytes).unwrap();
+            let res = borsh::from_slice::<ClassUri>(&class_uri_bytes).unwrap();
 
             assert_eq!(class_uri, res);
         }

ibc-apps/ics721-nft-transfer/types/src/data.rs

@@ -289,10 +289,8 @@ mod tests {
     #[test]
     fn test_borsh_roundtrip() {
         fn borsh_roundtrip(data_value: DataValue) {
-            use borsh::BorshDeserialize;
-
             let data_value_bytes = borsh::to_vec(&data_value).unwrap();
-            let res = DataValue::try_from_slice(&data_value_bytes).unwrap();
+            let res = borsh::from_slice::<DataValue>(&data_value_bytes).unwrap();
 
             assert_eq!(data_value, res);
         }

ibc-apps/ics721-nft-transfer/types/src/token.rs

@@ -245,10 +245,8 @@ mod tests {
     #[test]
     fn test_borsh_roundtrip() {
         fn borsh_roundtrip(token_uri: TokenUri) {
-            use borsh::BorshDeserialize;
-
             let token_uri_bytes = borsh::to_vec(&token_uri).unwrap();
-            let res = TokenUri::try_from_slice(&token_uri_bytes).unwrap();
+            let res = borsh::from_slice::<TokenUri>(&token_uri_bytes).unwrap();
 
             assert_eq!(token_uri, res);
         }

ibc-core/ics24-host/types/src/identifiers/chain_id.rs

@@ -440,17 +440,14 @@ mod tests {
     #[rstest]
     #[case(b"\x06\0\0\0foo-42\x45\0\0\0\0\0\0\0")]
     fn test_invalid_chain_id_borsh_deserialization(#[case] chain_id_bytes: &[u8]) {
-        use borsh::BorshDeserialize;
-
-        assert!(ChainId::try_from_slice(chain_id_bytes).is_err())
+        assert!(borsh::from_slice::<ChainId>(chain_id_bytes).is_err())
     }
 
     #[cfg(feature = "borsh")]
     fn borsh_ser_de_roundtrip(chain_id: ChainId) {
-        use borsh::BorshDeserialize;
-
         let chain_id_bytes = borsh::to_vec(&chain_id).unwrap();
-        let res = ChainId::try_from_slice(&chain_id_bytes).unwrap();
+        let res = borsh::from_slice::<ChainId>(&chain_id_bytes).unwrap();
+
         assert_eq!(chain_id, res);
     }
 

ibc-primitives/src/types/timestamp.rs

@@ -369,11 +369,9 @@ mod tests {
     #[test]
     #[cfg(feature = "borsh")]
     fn test_timestamp_borsh_ser_der() {
-        use borsh::BorshDeserialize;
-
         let timestamp = Timestamp::now();
         let encode_timestamp = borsh::to_vec(&timestamp).unwrap();
-        let _ = Timestamp::try_from_slice(&encode_timestamp).unwrap();
+        let _ = borsh::from_slice::<Timestamp>(&encode_timestamp).unwrap();
     }
 
     #[test]

ibc-testkit/src/fixtures/core/connection/conn_open_init.rs

@@ -183,9 +183,7 @@ mod tests {
 
         let serialized = borsh::to_vec(&msg).unwrap();
 
-        let msg_deserialized =
-            <MsgConnectionOpenInit as borsh::BorshDeserialize>::try_from_slice(&serialized)
-                .unwrap();
+        let msg_deserialized = borsh::from_slice::<MsgConnectionOpenInit>(&serialized).unwrap();
 
         assert_eq!(msg, msg_deserialized);
     }

ibc-testkit/src/fixtures/core/connection/conn_open_try.rs

@@ -200,8 +200,7 @@ mod tests {
 
         let serialized = borsh::to_vec(&msg).unwrap();
 
-        let msg_deserialized =
-            <MsgConnectionOpenTry as borsh::BorshDeserialize>::try_from_slice(&serialized).unwrap();
+        let msg_deserialized = borsh::from_slice::<MsgConnectionOpenTry>(&serialized).unwrap();
 
         assert_eq!(msg, msg_deserialized);
     }