Refactoring #14
Merged
Refactoring #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves costachung#11: Take the colorScheme from the system automatically
|
There is still an issue on MacOS that the view will not redraw itself automatically when user changes the appearance in system preferences. It works ok on iOS that we use init(dynamicProvider: @escaping (UITraitCollection) -> UIColor) to create the UIColor. When the system appearance changes. The view that use the color will redraw itself. With the current implementation for MacOS, the automatic-colorScheme-update only works on creation. it won't work on change. However, it will work on change if we put @Environment(.colorScheme) var colorScheme: ColorScheme in the view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of the Color Extension