Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add experimental support for Midea's NEC-like protocol. #1171

Merged
merged 8 commits into from
Jun 6, 2020
Merged

Add experimental support for Midea's NEC-like protocol. #1171

merged 8 commits into from
Jun 6, 2020

Conversation

crankyoldgit
Copy link
Owner

This protocol is basically NEC but extended to 48 bits with a single repeat.

Fixes #1170

@crankyoldgit crankyoldgit added enhancement Pending Confirmation Waiting for confirmation from user labels Jun 5, 2020
@crankyoldgit crankyoldgit requested a review from NiKiZe June 5, 2020 02:45
@crankyoldgit crankyoldgit self-assigned this Jun 5, 2020
@crankyoldgit crankyoldgit mentioned this pull request Jun 5, 2020
Closed
@crankyoldgit
Copy link
Owner Author

Thanks for the prompt review. I suspect this may change significantly if/when we get more data.
See: #1170 (comment)

@crankyoldgit
Copy link
Owner Author

i.e. this may only be a 16 or 24bits (of real data) protocol.

@crankyoldgit
Add experimental support for Midea's NEC-like protocol.
1426374 
This protocol is basically NEC but extended to 48 bits with a single repeat.

Fixes #1170
@crankyoldgit
Update Midea supported devices.
2c1c76a
@crankyoldgit
Add another test case.
e0c93c5 
Ref: #1170 (comment)
@crankyoldgit
More test cases.
7482541 
* More test cases/data for MideaNec
* Add (SEND|DECODE_MIDEA_NEC) to NEC `#if`s to ensure it is compiled.

Ref #1170
@crankyoldgit
Turn on debug and disable all other protocols.
9689b8f 
This is just for testing in #1170
Travis will break because of version number change.
This is on purpose so we don't accidentally push this change as is.
@crankyoldgit
Change to matchGeneric instead of decodeNEC
c6c7c7a 
* Add more tests to handle large timeout value.
* Revert some of temporary changes for debugging.
@crankyoldgit
Convert MIDEA_NEC to MIDEA24.
1aeccee 
* Change it from a 48 bit to a 24 bit protocol.
* Assume the 48 bits data consists of 8 bits of (real) data, followed by a bit-inverted 8 bits of that value. Thus 48 bits becomes 24.
* Update unit tests according (only changing the function names and the decoded values etc.
* Change method names, text, etc accordingly.

Fixes #1170
@crankyoldgit crankyoldgit removed the Pending Confirmation Waiting for confirmation from user label Jun 6, 2020
NiKiZe
NiKiZe approved these changes Jun 6, 2020
View reviewed changes
src/ir_NEC.cpp Show resolved Hide resolved
src/IRsend.h Outdated Show resolved Hide resolved
@crankyoldgit crankyoldgit requested a review from NiKiZe June 6, 2020 06:09
@crankyoldgit
Copy link
Owner Author

Okay, it's been converted to 24 bits and significantly different, hence it's appropriate for a re-review @NiKiZe

@crankyoldgit
Code Review feedback.
7b56f97 
- Fix indent.
@crankyoldgit crankyoldgit merged commit eaa3f5c into master Jun 6, 2020
@crankyoldgit crankyoldgit deleted the Issue1170 branch June 7, 2020 12:20
crankyoldgit added a commit that referenced this pull request Jun 22, 2020
@crankyoldgit
v2.7.7 release (#1132)
5ebd0bc 
_v2.7.8 (20200622)_

**[BREAKING CHANGES]**
- Fix Manchester code handling; Increase Airwell to `34` bits. (#1200)

**[Bug Fixes]**
- Carrier40: Use correct gap value. (#1193)

**[Features]**
- CarrierAc64: Add detailed support. (#1133)
- Add experimental support for Hitachi A/C 344 bit protocol (#1139)
- Automatic & full library code/API documentation via Doxygen (#1150 #1154 #1155 #1156 #1158 #1165 #1167 #1169 #1180 #1184 #1189 #1191 #1194 #1195 #1197 #1198)
- Hitachi344: Add detailed support and change bit ordering. (#1147)
- Add Corona AC Protocol (#1152)
- Hitachi344: Add Swing(H) and improve Swing(V) (#1148)
- Update auto_analyse_raw_data.py with better code comment sections (#1164)
- Add support for Midea24 protocol. (#1171)
- Add basic Zepeal protocol support (#1178)

**[Misc]**
- scrape_supported_devices.py: avoid changes to SupportedProtocols.md (#1140)
- auto_analyze nice exit on empty rawdata input (#1141)
- Comments update + cleanup (#1143)
- Update D_STR_IRRECVDUMP_STARTUP text and comments. (#1144)
- Minor code cleanups (#1149)
- Update `README.md`'s to point to new API docs. (#1151)
- Update "Supports" sections (#1160)
- Add a `doxygen` check to CI/Travis. (#1161)
- scrape_supported_devices: warn about misplaced or legacy supports sections (#1159)
- Add Supports sections to some files (#1163 #1166)
- Fix compile error when `DEBUG` is enabled.
- Add no-output option and return code on error to scrape_supported_devices
- Travis: Add scrape_supported_devices error check
- Update auto_analyse_raw_data.py to have a default Supports: section
- Treat compiler warnings as errors. (#1174)
- Remove `calcLGChecksum()` and use new generic `sumNibbles()` (#1175)
- Suppress more potential compiler warnings. (#1179)
- Load balance travis tasks to reduce wall clock time. (#1183)
- Set PlatformIO's default baudrate to 115200 (#1188)
- Some fixes to Doshisha protocol handler
- Minor cleanups of Corona and Zepeal
- Enable Doxygen warning when the parameters for a function/method/procedure are wrong/missing. (#1196)
crankyoldgit added a commit that referenced this pull request Jun 22, 2020
@crankyoldgit
v2.7.8 release
a6ee4e3 
_v2.7.8 (20200622)_

**[BREAKING CHANGES]**
- Fix Manchester code handling; Increase Airwell to `34` bits. (#1200)

**[Bug Fixes]**
- Carrier40: Use correct gap value. (#1193)

**[Features]**
- CarrierAc64: Add detailed support. (#1133)
- Add experimental support for Hitachi A/C 344 bit protocol (#1139)
- Automatic & full library code/API documentation via Doxygen (#1150 #1154 #1155 #1156 #1158 #1165 #1167 #1169 #1180 #1184 #1189 #1191 #1194 #1195 #1197 #1198)
- Hitachi344: Add detailed support and change bit ordering. (#1147)
- Add Corona AC Protocol (#1152)
- Hitachi344: Add Swing(H) and improve Swing(V) (#1148)
- Update auto_analyse_raw_data.py with better code comment sections (#1164)
- Add support for Midea24 protocol. (#1171)
- Add basic Zepeal protocol support (#1178)

**[Misc]**
- scrape_supported_devices.py: avoid changes to SupportedProtocols.md (#1140)
- auto_analyze nice exit on empty rawdata input (#1141)
- Comments update + cleanup (#1143)
- Update D_STR_IRRECVDUMP_STARTUP text and comments. (#1144)
- Minor code cleanups (#1149)
- Update `README.md`'s to point to new API docs. (#1151)
- Update "Supports" sections (#1160)
- Add a `doxygen` check to CI/Travis. (#1161)
- scrape_supported_devices: warn about misplaced or legacy supports sections (#1159)
- Add Supports sections to some files (#1163 #1166)
- Fix compile error when `DEBUG` is enabled.
- Add no-output option and return code on error to scrape_supported_devices
- Travis: Add scrape_supported_devices error check
- Update auto_analyse_raw_data.py to have a default Supports: section
- Treat compiler warnings as errors. (#1174)
- Remove `calcLGChecksum()` and use new generic `sumNibbles()` (#1175)
- Suppress more potential compiler warnings. (#1179)
- Load balance travis tasks to reduce wall clock time. (#1183)
- Set PlatformIO's default baudrate to 115200 (#1188)
- Some fixes to Doshisha protocol handler
- Minor cleanups of Corona and Zepeal
- Enable Doxygen warning when the parameters for a function/method/procedure are wrong/missing. (#1196)
@crankyoldgit crankyoldgit mentioned this pull request Jun 22, 2020
Merged
crankyoldgit added a commit that referenced this pull request Jun 23, 2020
@crankyoldgit
v2.7.8 release (#1201)
c705abd 
## _v2.7.8 (20200622)_

**[BREAKING CHANGES]**
- Fix Manchester code handling; Increase Airwell to `34` bits. (#1200)

**[Bug Fixes]**
- Carrier40: Use correct gap value. (#1193)

**[Features]**
- CarrierAc64: Add detailed support. (#1133)
- Add experimental support for Hitachi A/C 344 bit protocol (#1139)
- Automatic & full library code/API documentation via Doxygen (#1150 #1154 #1155 #1156 #1158 #1165 #1167 #1169 #1180 #1184 #1189 #1191 #1194 #1195 #1197 #1198)
- Hitachi344: Add detailed support and change bit ordering. (#1147)
- Add Corona AC Protocol (#1152)
- Hitachi344: Add Swing(H) and improve Swing(V) (#1148)
- Update auto_analyse_raw_data.py with better code comment sections (#1164)
- Add support for Midea24 protocol. (#1171)
- Add basic Zepeal protocol support (#1178)

**[Misc]**
- scrape_supported_devices.py: avoid changes to SupportedProtocols.md (#1140)
- auto_analyze nice exit on empty rawdata input (#1141)
- Comments update + cleanup (#1143)
- Update D_STR_IRRECVDUMP_STARTUP text and comments. (#1144)
- Minor code cleanups (#1149)
- Update `README.md`'s to point to new API docs. (#1151)
- Update "Supports" sections (#1160)
- Add a `doxygen` check to CI/Travis. (#1161)
- scrape_supported_devices: warn about misplaced or legacy supports sections (#1159)
- Add Supports sections to some files (#1163 #1166)
- Fix compile error when `DEBUG` is enabled.
- Add no-output option and return code on error to scrape_supported_devices
- Travis: Add scrape_supported_devices error check
- Update auto_analyse_raw_data.py to have a default Supports: section
- Treat compiler warnings as errors. (#1174)
- Remove `calcLGChecksum()` and use new generic `sumNibbles()` (#1175)
- Suppress more potential compiler warnings. (#1179)
- Load balance travis tasks to reduce wall clock time. (#1183)
- Set PlatformIO's default baudrate to 115200 (#1188)
- Some fixes to Doshisha protocol handler
- Minor cleanups of Corona and Zepeal
- Enable Doxygen warning when the parameters for a function/method/procedure are wrong/missing. (#1196)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiKiZe NiKiZe Awaiting requested review from NiKiZe

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

recv unknown encoding!
2 participants
@crankyoldgit @NiKiZe