Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING BUG] Fix Manchester code handling; Increase Airwell to 34 bits. #1200

Merged
merged 6 commits into from
Jun 22, 2020
Merged

[BREAKING BUG] Fix Manchester code handling; Increase Airwell to 34 bits. #1200

merged 6 commits into from
Jun 22, 2020

Conversation

crankyoldgit
Copy link
Owner

  • [BREAKING] Airwell changing from 32 to 34 bits. All previous codes are invalid.
  • [BREAKING] Remove sync bits from sendManchester & IRrecv::matchManchester() etal.
  • Add IRrecv::matchManchesterData() method.
    • Try a different (better?) approach to handle matching Manchester code data portions.
  • Rewrite of decodeManchester()
  • Update unit tests accordingly.
  • Add more unit tests to fix/find/identify bugs.

Fixes #1199 (Hopefully)

@crankyoldgit
Add IRrecv:matchManchesterData() method.
61d4735 
Try a different (better?) approach to handle matching Manchester code data portions.

For #1199
@crankyoldgit
[BREAKING] Airwell: Change bit size to 34 & fix Manchester code.
6bd6115 
* BREAKING: Airwell: 32 -> 34 bits. All previous codes are invalid.
* [BREAKING] Remove expecting sync bits from sendManchester etal.
* [BREAKING] Rework & rewrite `decodeManchester()`
* Update unit tests accordingly
* Add unit test for #1199 (comment)

Fixes #1199 (Hopefully)
@crankyoldgit crankyoldgit added bug enhancement Pending Confirmation Waiting for confirmation from user labels Jun 21, 2020
@crankyoldgit crankyoldgit self-assigned this Jun 21, 2020
@crankyoldgit
Copy link
Owner Author

Hi Code reviewers, this is a big/horrible change. Please take your time reviewing it. It's not neat or clean (yet) but it does seem to work.

@crankyoldgit crankyoldgit mentioned this pull request Jun 21, 2020
Closed
@crankyoldgit crankyoldgit mentioned this pull request Jun 21, 2020
Closed
@crankyoldgit
Copy link
Owner Author

P.S. I offically hate Manchester Code. It's easy enough to send and decode if that's the only protocol you need to deal with, and if you are NOT capturing/storing the data like this library does.
It really wants to be done in real-time, not via post-analysis.

NiKiZe
NiKiZe reviewed Jun 21, 2020
View reviewed changes
test/ir_Airwell_test.cpp Outdated Show resolved Hide resolved
@crankyoldgit
Code review feedback.
7e0362d 
Replace a synthetic example with a real value (from RealExample3)
@crankyoldgit
Copy link
Owner Author

Confirmed working in #1199 (comment)

@crankyoldgit crankyoldgit removed the Pending Confirmation Waiting for confirmation from user label Jun 22, 2020
@crankyoldgit
Clean up matchManchesterData()
35371c7 
* Remove debug code.
* Add more/better comments.
* Cleanup code appearence.
* No structural changes.
@crankyoldgit
Clean up of matchManchester()
924a26e 
* Remove old/obsolete comments
* Correct shortest length case.
* Change `bank` to `uint16_t` as it can't go negative.
* Remove whitespace.
@crankyoldgit crankyoldgit merged commit 1d211fd into master Jun 22, 2020
@crankyoldgit crankyoldgit deleted the manchester_redo branch June 22, 2020 05:27
crankyoldgit added a commit that referenced this pull request Jun 22, 2020
@crankyoldgit
v2.7.7 release (#1132)
5ebd0bc 
_v2.7.8 (20200622)_

**[BREAKING CHANGES]**
- Fix Manchester code handling; Increase Airwell to `34` bits. (#1200)

**[Bug Fixes]**
- Carrier40: Use correct gap value. (#1193)

**[Features]**
- CarrierAc64: Add detailed support. (#1133)
- Add experimental support for Hitachi A/C 344 bit protocol (#1139)
- Automatic & full library code/API documentation via Doxygen (#1150 #1154 #1155 #1156 #1158 #1165 #1167 #1169 #1180 #1184 #1189 #1191 #1194 #1195 #1197 #1198)
- Hitachi344: Add detailed support and change bit ordering. (#1147)
- Add Corona AC Protocol (#1152)
- Hitachi344: Add Swing(H) and improve Swing(V) (#1148)
- Update auto_analyse_raw_data.py with better code comment sections (#1164)
- Add support for Midea24 protocol. (#1171)
- Add basic Zepeal protocol support (#1178)

**[Misc]**
- scrape_supported_devices.py: avoid changes to SupportedProtocols.md (#1140)
- auto_analyze nice exit on empty rawdata input (#1141)
- Comments update + cleanup (#1143)
- Update D_STR_IRRECVDUMP_STARTUP text and comments. (#1144)
- Minor code cleanups (#1149)
- Update `README.md`'s to point to new API docs. (#1151)
- Update "Supports" sections (#1160)
- Add a `doxygen` check to CI/Travis. (#1161)
- scrape_supported_devices: warn about misplaced or legacy supports sections (#1159)
- Add Supports sections to some files (#1163 #1166)
- Fix compile error when `DEBUG` is enabled.
- Add no-output option and return code on error to scrape_supported_devices
- Travis: Add scrape_supported_devices error check
- Update auto_analyse_raw_data.py to have a default Supports: section
- Treat compiler warnings as errors. (#1174)
- Remove `calcLGChecksum()` and use new generic `sumNibbles()` (#1175)
- Suppress more potential compiler warnings. (#1179)
- Load balance travis tasks to reduce wall clock time. (#1183)
- Set PlatformIO's default baudrate to 115200 (#1188)
- Some fixes to Doshisha protocol handler
- Minor cleanups of Corona and Zepeal
- Enable Doxygen warning when the parameters for a function/method/procedure are wrong/missing. (#1196)
crankyoldgit added a commit that referenced this pull request Jun 22, 2020
@crankyoldgit
v2.7.8 release
a6ee4e3 
_v2.7.8 (20200622)_

**[BREAKING CHANGES]**
- Fix Manchester code handling; Increase Airwell to `34` bits. (#1200)

**[Bug Fixes]**
- Carrier40: Use correct gap value. (#1193)

**[Features]**
- CarrierAc64: Add detailed support. (#1133)
- Add experimental support for Hitachi A/C 344 bit protocol (#1139)
- Automatic & full library code/API documentation via Doxygen (#1150 #1154 #1155 #1156 #1158 #1165 #1167 #1169 #1180 #1184 #1189 #1191 #1194 #1195 #1197 #1198)
- Hitachi344: Add detailed support and change bit ordering. (#1147)
- Add Corona AC Protocol (#1152)
- Hitachi344: Add Swing(H) and improve Swing(V) (#1148)
- Update auto_analyse_raw_data.py with better code comment sections (#1164)
- Add support for Midea24 protocol. (#1171)
- Add basic Zepeal protocol support (#1178)

**[Misc]**
- scrape_supported_devices.py: avoid changes to SupportedProtocols.md (#1140)
- auto_analyze nice exit on empty rawdata input (#1141)
- Comments update + cleanup (#1143)
- Update D_STR_IRRECVDUMP_STARTUP text and comments. (#1144)
- Minor code cleanups (#1149)
- Update `README.md`'s to point to new API docs. (#1151)
- Update "Supports" sections (#1160)
- Add a `doxygen` check to CI/Travis. (#1161)
- scrape_supported_devices: warn about misplaced or legacy supports sections (#1159)
- Add Supports sections to some files (#1163 #1166)
- Fix compile error when `DEBUG` is enabled.
- Add no-output option and return code on error to scrape_supported_devices
- Travis: Add scrape_supported_devices error check
- Update auto_analyse_raw_data.py to have a default Supports: section
- Treat compiler warnings as errors. (#1174)
- Remove `calcLGChecksum()` and use new generic `sumNibbles()` (#1175)
- Suppress more potential compiler warnings. (#1179)
- Load balance travis tasks to reduce wall clock time. (#1183)
- Set PlatformIO's default baudrate to 115200 (#1188)
- Some fixes to Doshisha protocol handler
- Minor cleanups of Corona and Zepeal
- Enable Doxygen warning when the parameters for a function/method/procedure are wrong/missing. (#1196)
@crankyoldgit crankyoldgit mentioned this pull request Jun 22, 2020
Merged
crankyoldgit added a commit that referenced this pull request Jun 23, 2020
@crankyoldgit
v2.7.8 release (#1201)
c705abd 
## _v2.7.8 (20200622)_

**[BREAKING CHANGES]**
- Fix Manchester code handling; Increase Airwell to `34` bits. (#1200)

**[Bug Fixes]**
- Carrier40: Use correct gap value. (#1193)

**[Features]**
- CarrierAc64: Add detailed support. (#1133)
- Add experimental support for Hitachi A/C 344 bit protocol (#1139)
- Automatic & full library code/API documentation via Doxygen (#1150 #1154 #1155 #1156 #1158 #1165 #1167 #1169 #1180 #1184 #1189 #1191 #1194 #1195 #1197 #1198)
- Hitachi344: Add detailed support and change bit ordering. (#1147)
- Add Corona AC Protocol (#1152)
- Hitachi344: Add Swing(H) and improve Swing(V) (#1148)
- Update auto_analyse_raw_data.py with better code comment sections (#1164)
- Add support for Midea24 protocol. (#1171)
- Add basic Zepeal protocol support (#1178)

**[Misc]**
- scrape_supported_devices.py: avoid changes to SupportedProtocols.md (#1140)
- auto_analyze nice exit on empty rawdata input (#1141)
- Comments update + cleanup (#1143)
- Update D_STR_IRRECVDUMP_STARTUP text and comments. (#1144)
- Minor code cleanups (#1149)
- Update `README.md`'s to point to new API docs. (#1151)
- Update "Supports" sections (#1160)
- Add a `doxygen` check to CI/Travis. (#1161)
- scrape_supported_devices: warn about misplaced or legacy supports sections (#1159)
- Add Supports sections to some files (#1163 #1166)
- Fix compile error when `DEBUG` is enabled.
- Add no-output option and return code on error to scrape_supported_devices
- Travis: Add scrape_supported_devices error check
- Update auto_analyse_raw_data.py to have a default Supports: section
- Treat compiler warnings as errors. (#1174)
- Remove `calcLGChecksum()` and use new generic `sumNibbles()` (#1175)
- Suppress more potential compiler warnings. (#1179)
- Load balance travis tasks to reduce wall clock time. (#1183)
- Set PlatformIO's default baudrate to 115200 (#1188)
- Some fixes to Doshisha protocol handler
- Minor cleanups of Corona and Zepeal
- Enable Doxygen warning when the parameters for a function/method/procedure are wrong/missing. (#1196)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiKiZe NiKiZe NiKiZe approved these changes

@sillyfrog sillyfrog Awaiting requested review from sillyfrog

Assignees

@crankyoldgit crankyoldgit

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIRWELL Support
2 participants
@crankyoldgit @NiKiZe