-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demoting alpine images to alpine 3.12 #127
Demoting alpine images to alpine 3.12 #127
Conversation
Did you try upgrading to 3.14? |
@jhass yes, same thing |
Bummer :( |
Chiming on this 👋🏽 A side effect of the 3.13 upgrade resulted in reduced performance of statically linked binaries. A simple HTTP Hello world with 3.13 produces half number of requests (synthetic benchmark) of the exact same code built under Alpine 3.12 using the same compiler version. Here is the used dockerfile (change Wasn't able to dig deeper but something changed in newer versions of Alpine that could be connected. |
Hmmm. It seems something broke, probably with this PR because I think is the only changing the linux packaging by the maintenance build failed
|
Perhaps relevant @bcardiff, but
This does not happen with 3.13 or 3.14:
|
Also, it appears my previous analysis is no longer accurate (as today, November 20). Synthetic micro benchmark of basic HTTP server against localhost, this time Crystal 1.2.1 on multiple versions of Alpine: # A very basic HTTP server
require "http/server"
server = HTTP::Server.new do |context|
context.response.content_type = "text/plain"
context.response.print "Hello world!"
end
Signal::INT.trap do
puts "Shutdown requested."
server.close
end
ipaddr = server.bind_tcp("0.0.0.0", 8080)
puts "Listening on http://#{ipaddr.address}:#{ipaddr.port}/"
server.listen Crystal 1.2.1 on Alpine 3.12 (best of 3 bench):
Crystal 1.2.1 on Alpine 3.13 (best of 3 bench):
Crystal 1.2.1 on Alpine 3.14 (best of 3 bench):
|
Upgrade to latest Alpine (3.14) to solve busybox-related security warnings that are causing the build to fail. Remove the note about performance issues associated with Alpine 3.13 or newer as these were no longer possible to prove. Ref: crystal-lang/distribution-scripts#127 (comment)
Solves crystal/#10366 by partially undoing #79 .