-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix alpine Dockerfile to add *-static packages and update to alpine 3.13 #79
Conversation
And remove unnecessary *-dev because they're already dependencies of *-static
Included in llvm10-static
In #68 that was changed here https://github.com/crystal-lang/distribution-scripts/pull/68/files#diff-c306b13048e7d0a5c50f527d9ff3fbcd7deb85a451c5bdad725a10f9e2b2322cL48 but not here https://github.com/crystal-lang/distribution-scripts/blob/master/docker/alpine.Dockerfile#L8 Are you sure you prefer to use different alpine base images while building the binaries and distributing the docker images? If we want to bump entirely to alpine 3.13 we need to change Whatever is decided, I can rebuilt the alpine 0.36 image with these changes and republish it. |
Yeah, I noticed that, too. We should probably try to avoid this duplication. IIRC there was some effort about unifying both dockerfiles / re-using the alpine dockerfile for the linux build. Would've definitely helped here.
I didn't look into the base image version used for linux build. But I suppose we should probably update that to 3.13 as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I re-upload the 0.36 alpine docker image with alpine:3.13 or 3.12 then?
3.13 sounds better I think. |
@@ -31,6 +31,6 @@ FROM runtime as build | |||
|
|||
RUN \ | |||
apk add --update --no-cache --force-overwrite \ | |||
llvm10-dev llvm10-static g++ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolves crystal-lang/crystal#10313