[WIP] adding https guide to installation guide

[alex9311]

will someone please try out the steps in this guide

#452

[bsekachev]

SSH?

[thusinh1969]

Would really LOVE to know how to setup SSL. Keys can be getting from Cloudflare for examples ?

Thanks much.
Steve

[bsekachev]

It seems to me, we should do it through environment variables

[bsekachev]

Instead of the hardcoded True value

[nmanovic]

@alex9311 , is it possible to provide instructions which don't require modify source code? It is OK to add a couple of more files or redefine some environment variables but I don't think that it is good to ask users to modify original source code to enable a feature.

[nmanovic]

@alex9311 , one more comment. Need to add information about the feature into CHANGELOG.md

[nmanovic]

@alex9311 , will you find time to fix our comments and slightly improve the PR?

[alex9311]

hi @nmanovic , yeah I should have time this weekend

[alex9311]

I can easily read from an environment variable to set SECURE_SSL_REDIRECT instead of asking the user to modify cvat/settings/base.py. Are you also unhappy with the use of a docker-compose.override.yml file? Or is that OK?

The generation of SLL certificates in the Dockerfile is just a suggestion, there are a lot of different ways users could get those key and cert files. I could remove the Docker suggestion and just tell the user they will need to put their certs at /etc/ssl/cvat-certs/.

[nmanovic]

@alex9311 ,

I can easily read from an environment variable to set SECURE_SSL_REDIRECT instead of asking the user to modify cvat/settings/base.py.

It will be better because in this case we can use docker-compose.override.yml to provide the value.

Are you also unhappy with the use of a docker-compose.override.yml file? Or is that OK?

It is OK.

The generation of SLL certificates in the Dockerfile is just a suggestion, there are a lot of different ways users could get those key and cert files. I could remove the Docker suggestion and just tell the user they will need to put their certs at /etc/ssl/cvat-certs/.

Probably it is better to ask users to put certificates into a directory on host (e.g. cvat source code/ssl). But if you give an example how to generate a dummy certificate in your README file it will be good.

[thusinh1969]

Would really LOVE to know how to setup SSL. Keys can be getting from Cloudflare for examples ?

Thanks much.
Steve

[nmanovic]

@alex9311 , please let me know if you are going to fix comments.

[nmanovic]

@alex9311 , it seems you don't have time to finish the PR. I will close it right now.