Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Upgrade tus-js-client from 2.3.2 to 3.0.1 #5140

Merged
merged 2 commits into from
Oct 18, 2022

Conversation

azhavoro
Copy link
Contributor

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to upgrade tus-js-client from 2.3.2 to 3.0.1.

merge advice
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


Warning: This is a major version upgrade, and may be a breaking change.

  • The recommended version is 3 versions ahead of your current version.
  • The recommended version was released a month ago, on 2022-09-09.
Release notes
Package name: tus-js-client from tus-js-client GitHub release notes
Commit messages
Package name: tus-js-client

Compare


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

🧐 View latest project report

🛠 Adjust upgrade PR settings

🔕 Ignore this dependency or unsubscribe from future upgrade PRs

@bsekachev
Copy link
Member

@klakhov Do you think we can update tus?

@bsekachev bsekachev added the dependencies Pull requests that update a dependency file label Oct 18, 2022
@klakhov
Copy link
Contributor

klakhov commented Oct 18, 2022

@bsekachev let me check if everything works correctly after update

@klakhov
Copy link
Contributor

klakhov commented Oct 18, 2022

/check

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2022

✔️ All checks completed successfully
📄 See logs here

@nmanovic
Copy link
Contributor

@klakhov , should we update the lock file?

@sizov-kirill
Copy link
Contributor

There is no any vulnerabilities, so I guess we can close this PR.
The reason why Snyk sent this PR is "Upgrade out-of-date dependency" option that was enabled for our repository.
I think that updating dependencies without any vulnerabilities is unnecessary so I disabled this option and expect that we won't receive such PRs in future.

@klakhov
Copy link
Contributor

klakhov commented Oct 18, 2022

/check

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2022

❌ Some checks failed
📄 See logs here

@klakhov
Copy link
Contributor

klakhov commented Oct 18, 2022

@bsekachev Could you look on failing test with multi-tasks? Do we need to merge develop to avoid this?

@bsekachev
Copy link
Member

@klakhov

Looks like timeout issue. It is not related with this patch. Just bad connection with GitHub..

Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I think we can merge this, tested locally, didn't meet any issues

@bsekachev bsekachev merged commit 3680990 into develop Oct 18, 2022
@bsekachev bsekachev deleted the snyk-upgrade-ddb0d6cf8c3989751c8474eccb826ccb branch October 18, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants