Check ground truth annotations in GT job #7770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, add also a check that we have object menu for GT objects in GT job, and does not have, in a regular job. |
bsekachev
reviewed
Apr 17, 2024
Comment on lines
320
to
322
| cy.get(`#cvat-objects-sidebar-state-item-${groundTruthRectangles[index].id}`) | ||
| .find('.ant-dropdown-trigger').click(); | ||
| cy.get('.cvat-object-item-menu').should('exist'); |
There was a problem hiding this comment.
May we move it inside checkRectangle to reduce code duplication?
bsekachev
reviewed
Apr 17, 2024
| cy.goCheckFrameNumber(frame); | ||
| checkRectangle(groundTruthRectangles[index], true); | ||
| cy.get(`#cvat-objects-sidebar-state-item-${groundTruthRectangles[index].id}`) | ||
| .find('.ant-dropdown-trigger').click(); |
There was a problem hiding this comment.
Instead of using .antd defined class, I will suggest to add CVAT class name to this element (e.g. cvat-object-item-menu-button) and use it.
Also we do not need click the element, just checking that it exists and visible is enough
bsekachev
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Update ground truth job test by covering the case in #7714
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.