Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check ground truth annotations in GT job #7770

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Check ground truth annotations in GT job #7770

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9e6ebaa
check ground truth annotations in gt job
novda Apr 15, 2024
366f4cd
add check object menu
novda Apr 16, 2024
eeb6921
add understandable classname to menu-button and refactor test
novda Apr 17, 2024
6fd4aa5
refactor test
novda Apr 18, 2024
8827d16
fix get button selector
novda Apr 18, 2024
a0a497a
fix assert chainer type
novda Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions tests/cypress/e2e/features/ground_truth_jobs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,19 @@ context('Ground truth jobs', () => {
});
}

function checkRectangle(rectangle) {
cy.get(`#cvat_canvas_shape_${rectangle.id}`)
.should('be.visible')
.should('have.class', 'cvat_canvas_ground_truth');
function checkRectangle(rectangle, isGroundTruthJob = false) {
if (isGroundTruthJob) {
cy.get(`#cvat_canvas_shape_${rectangle.id}`)
.should('be.visible')
.should('not.have.class', 'cvat_canvas_ground_truth')
.should('not.have.css', 'stroke-dasharray', '1px');
} else {
cy.get(`#cvat_canvas_shape_${rectangle.id}`)
.should('be.visible')
.should('have.class', 'cvat_canvas_ground_truth')
.should('have.css', 'stroke-dasharray', '1px');
}

cy.get(`#cvat-objects-sidebar-state-item-${rectangle.id}`)
.should('be.visible');
}
Expand Down Expand Up @@ -295,14 +304,24 @@ context('Ground truth jobs', () => {
});
});

it('Check ground truth annotations in regular job', () => {
it('Check ground truth annotations in GT job and in regular job', () => {
cy.interactMenu('Open the task');
cy.get('.cvat-job-item').contains('a', `Job #${groundTruthJobID}`).click();

groundTruthFrames.forEach((frame, index) => {
cy.goCheckFrameNumber(frame);
cy.createRectangle(groundTruthRectangles[index]);
});

cy.changeWorkspace('Review');
groundTruthFrames.forEach((frame, index) => {
cy.goCheckFrameNumber(frame);
checkRectangle(groundTruthRectangles[index], true);
cy.get(`#cvat-objects-sidebar-state-item-${groundTruthRectangles[index].id}`)
.find('.ant-dropdown-trigger').click();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using .antd defined class, I will suggest to add CVAT class name to this element (e.g. cvat-object-item-menu-button) and use it.

Also we do not need click the element, just checking that it exists and visible is enough

cy.get('.cvat-object-item-menu').should('exist');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May we move it inside checkRectangle to reduce code duplication?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved

});

cy.saveJob();
cy.interactMenu('Finish the job');
cy.get('.cvat-modal-content-finish-job').within(() => {
Expand All @@ -316,6 +335,8 @@ context('Ground truth jobs', () => {
groundTruthFrames.forEach((frame, index) => {
cy.goCheckFrameNumber(frame);
checkRectangle(groundTruthRectangles[index]);
cy.get(`#cvat-objects-sidebar-state-item-${groundTruthRectangles[index].id}`)
.find('.ant-dropdown-trigger').should('not.exist');
});
});

Expand Down
Loading