Fix gscan exception hook dialog closure incapacity #2579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewrmshin
approved these changes
Feb 15, 2018
hjoliver
approved these changes
Feb 15, 2018
matthewrmshin
added a commit
to matthewrmshin/cylc-flow
that referenced
this pull request
Mar 26, 2018
* cylc#2606 Fix poll when job.status has no batch sys info * cylc#2604 Lowercase for shell bool vars * cylc#2603 Fix gui insert nested family * cylc#2602 gcylc: prevent negative job progress * cylc#2596 Fix ref by value of parameters with plus/minus * cylc#2592 Permit syntax errors with trigger edits * cylc#2588 Fix trigger --edit with host select * cylc#2586 Fix gcylc zero division error from task mean elapsed time * cylc#2585 Fix recovery of a failed host select command * cylc#2579 Fix gscan exception hook dialog closure incapacity * cylc#2574 Fix gscan host port range owner behaviour * cylc#2571 gcylc: fix tailer of remote job log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst reviewing #2574 I noticed that when I obtained a exception traceback in
gscanin a pop-up dialog window, the window would immediately re-open after being prompted to close via clicking of the 'OK' button or the 'Close Window' cross corner iron (ad infinitum with further attempts to close it).To recreate: open gscan so it provides any 'entry' traceback e.g. by providing invalid arguments to it such as
cylc gscan -o '*' -n '*'or by editing the code inlib/cylc/gui/gscan.pyto create an error there.I have resolved this by changing an argument so that (as I understand the logic) the
set_exception_hook_dialogfunction will only launch an exception dialog if it has not already been launched. The variableold_hookwas in fact already initialised within the function but not implemented in this way; it seems (?) the original writer intended to include it as an argument to_launch_exception_hook_dialogfunction but mistakenly putsys.excepthookinstead.