Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recovery of a failed host select command #2585

Merged

Conversation

matthewrmshin
Copy link
Contributor

Recovery of a failed host select command was a bit broken. This change
ensures that the result is reset as soon as it is consumed.

This also ensures that the retry timer is set for submission retry on host select command failure.

Recovery of a failed host select command was a bit broken. This change
ensures that the result is reset as soon as it is consumed.
@matthewrmshin matthewrmshin added the bug Something is wrong :( label Feb 23, 2018
@matthewrmshin matthewrmshin added this to the next release milestone Feb 23, 2018
@matthewrmshin matthewrmshin self-assigned this Feb 23, 2018
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tests as working.

@hjoliver hjoliver merged commit f7e71db into cylc:master Feb 27, 2018
@matthewrmshin matthewrmshin deleted the bad-host-select-command-recovery branch February 27, 2018 09:18
matthewrmshin added a commit to matthewrmshin/cylc-flow that referenced this pull request Mar 23, 2018
* cylc#2606 Fix poll when job.status has no batch sys info
* cylc#2603 Fix gui insert nested family
* cylc#2588 Fix trigger --edit with host select
* cylc#2585 Fix recovery of a failed host select command
* cylc#2574 Fix gscan host port range owner behaviour
matthewrmshin added a commit to matthewrmshin/cylc-flow that referenced this pull request Mar 26, 2018
* cylc#2606 Fix poll when job.status has no batch sys info
* cylc#2604 Lowercase for shell bool vars
* cylc#2603 Fix gui insert nested family
* cylc#2602 gcylc: prevent negative job progress
* cylc#2596 Fix ref by value of parameters with plus/minus
* cylc#2592 Permit syntax errors with trigger edits
* cylc#2588 Fix trigger --edit with host select
* cylc#2586 Fix gcylc zero division error from task mean elapsed time
* cylc#2585 Fix recovery of a failed host select command
* cylc#2579 Fix gscan exception hook dialog closure incapacity
* cylc#2574 Fix gscan host port range owner behaviour
* cylc#2571 gcylc: fix tailer of remote job log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants