id: pass tokens objects between interfaces #5328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
oliver-sanders
force-pushed
the
data-store-opt
branch
2 times, most recently
from
1b5518e
to
abd7cd1
Compare
8 tasks
oliver-sanders
force-pushed
the
data-store-opt
branch
from
abd7cd1
to
0aa723b
Compare
* Change `TaskProxy.tokens` to hold the absolute ID rather than the relative ID to make the object useful in more situations. * Refactor the data_store_mgr interfaces to accept `Tokens` instances rather than raw inputs (e.g. cycle_point, task_name, etc). * This avoids doing `Tokens(str(tokens))` when passing context into the data store interfaces.
oliver-sanders
force-pushed
the
data-store-opt
branch
from
0aa723b
to
6322f15
Compare
MetRonnie
reviewed
Mar 8, 2023
Comment on lines
-2214
to
+2236
| node_type = TASKS | ||
| elif sub_num is None: | ||
| node_id = self.id_.duplicate( | ||
| cycle=str(point), | ||
| task=name, | ||
| ).id | ||
| else: | ||
| node_id = self.id_.duplicate( | ||
| cycle=str(point), | ||
| task=name, | ||
| job=str(sub_num), | ||
| ).id | ||
| node_type = JOBS | ||
| node_type = { | ||
| 'task': TASK_PROXIES, |
There was a problem hiding this comment.
Before this was TASKS, just want to make sure this is correct
There was a problem hiding this comment.
This had three branches for TASK_PROXIES (kwarg default), TASKS and JOBS.
The TASKS branch wasn't used so I dropped it (all store_node_fetcher calls provided the point argument).
MetRonnie
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TaskProxy.tokensto hold the absolute ID rather than therelative ID to make the object useful in more situations.
Tokensinstancesrather than raw inputs (e.g. cycle_point, task_name, etc).
Tokens(str(tokens))when passing context into thedata store interfaces.
Tested using this simple workflow which evaluates the scaling performance of internal-queues/job-submission/management against the number of tasks (note there are no dependencies or cycles to negotiate):
With
-s TASKS=100 -s LIMIT=100:Before: 9.2s
After: 6.56s
Saving: ~28%
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.