8.1.x #5327
Merged
8.1.x #5327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profiling revealed `Tokens.relative_id()` was being called many times and was acting as a bit of a bottleneck. - Remove a couple of unecessary nested comprehensions - Precompute certain sets
Optimize ID/tokens code
Where name is `workflow` and id is `workflow/runX` or `workflow/name`. mypy fix
data-store graph window efficiency/refactor
Allow Cylc VIP to work with named runs.
…type (#5312) * treat items in queues as implicit tasks * made tasks implied by queues a warning only. Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
8 tasks
- Do not create tables by default, only if specified via kwarg - Provide context manager functionality to automatically close DB connection - A WorkflowDatabaseManager should only be created by Scheduler; just use CylcWorkflowDAO elsewhere
Co-authored-by: Tim Pillinger <26465611+wxtim@users.noreply.github.com>
DB interface & safety improvements
MetRonnie
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync PR: please do not squash-merge