Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: proxy logging #16730

Merged
merged 60 commits into from
Aug 2, 2021
Merged

feat: proxy logging #16730

merged 60 commits into from
Aug 2, 2021

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented May 28, 2021

User facing changelog

  • The logging experience around HTTP requests has been updated.

Additional details

  • added listener + request:event response:received for CDP Network.responseReceived
  • added request:event request:error
  • renamed net:event to net:stubbing:event now that request:events exist

How has the user experience changed?

before: image

not current after: ![image](https://user-images.githubusercontent.com/1151760/126188624-0f52f60d-1c59-431b-8e92-b2781cfbba7e.png)

after final:
image

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@flotwig flotwig requested a review from a team as a code owner May 28, 2021 19:19
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 28, 2021

Thanks for taking the time to open a PR!

@flotwig flotwig requested review from chrisbreiding and kuceb and removed request for a team May 28, 2021 19:19
@flotwig flotwig marked this pull request as draft June 1, 2021 15:24
@flotwig flotwig marked this pull request as ready for review July 26, 2021 14:30
Copy link
Contributor

@kuceb kuceb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flotwig
Copy link
Contributor Author

flotwig commented Aug 2, 2021

@bkucera it's expected, due to this no longer using <Aliases> for HTTP requests but <Interceptions>, but I can update the test to minimize the diff if you'd like.

edit: Test updated.

Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
@jennifer-shehane
Copy link
Member

The percy snapshots that I didn't approve are a bit weird in their diff. Not sure if this is just a percy anomaly.

@chrisbreiding chrisbreiding self-requested a review August 2, 2021 19:31
chrisbreiding
chrisbreiding previously approved these changes Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Condense XHRs and cy.intercept requests together cy.intercept is shown as processing
4 participants