chore(tests): fix flake in net stubbing/xhr/proxy logging tests #18163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flotwig
requested review from
chrisbreiding and
jennifer-shehane
and removed request for
a team
|
Thanks for taking the time to open a PR!
|
flotwig
changed the title
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||
flotwig
changed the title
flotwig
force-pushed
the
issue-17629-flaky-logging-tests
branch
from
d263d2d
to
cfe98cc
Compare
flotwig
force-pushed
the
issue-17629-flaky-logging-tests
branch
from
919085f
to
409f199
Compare
jennifer-shehane
approved these changes
Sep 21, 2021
tgriesser
added a commit
that referenced
this pull request
Sep 24, 2021
…/remove-decorators * unified-desktop-gui: fixing broken ct tests fix types remove old code chore: bump deps (#18213) feat(app): icon library supporting Cy's custom icons (#18195) feat(app): adding navigation, pages, router, and layout (#18194) chore: Update Chrome (stable) to 94.0.4606.54 (#18196) chore: bump yarn.lock (#18204) chore(tests): fix flake in net stubbing/xhr/proxy logging tests (#18163) chore: Update Chrome (beta) to 94.0.4606.54 (#18174) fix: add deprecation notice for win 32-bit (#18130) chore: fix broken firefox focus tests, bump resource class of chrome-beta job (#18133) fix(cli): Respect NO_PROXY on cypress download (#17702) chore: Update Chrome (beta) to 94.0.4606.50 (#18117) release 8.4.1 [skip ci] fix: GH env variable for test other projects (#18147) fix(open_project): remove unnecessary fn wrapping from tryToCalls (#18146) change @ts-expect-error -> @ts-ignore (#18047)
tgriesser
added a commit
that referenced
this pull request
Sep 28, 2021
* unified-desktop-gui: (48 commits) refactor: remove nexus-decorators, add data context (#18211) fix mountFragment tests fix(unified-desktop-gui branch): initial installation on windows (#18247) fix(unify): fixing icons and supporting router within the shared cypress commands package (#18237) feat(launchpad): improve layout and design (#18238) feat(launchpad): add design tokens from Figma (#18223) fix(unify): appveyor windows issue + better icon types (#18226) fixing broken ct tests fix types remove old code chore: bump deps (#18213) feat(app): icon library supporting Cy's custom icons (#18195) feat(app): adding navigation, pages, router, and layout (#18194) chore: Update Chrome (stable) to 94.0.4606.54 (#18196) fix(launchpad): fix bugs introduced by urql/graphcache (#18193) chore: bump yarn.lock (#18204) feat: add gulp makePackage, begin to scaffold data-context (#18186) feat(launchpad): Directory Upload in Global Mode (#18165) chore(tests): fix flake in net stubbing/xhr/proxy logging tests (#18163) chore: remove nxs.gen.ts - should be created by codegen (#18184) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
n/a
Additional details
There are 2 main reasons these tests were flaky after #16730:
xhr.jscode still since they can be totally stubbed bycy.route(), which will bypass feat: proxy logging #16730 entirely. But if the XHR does go out-of-browser, the XHR log will be updated with proxy logging metadata either before or after the XHRonloadevent fires. (similar to (1))Also bonus attempted to fix flake in net_stubbing_spec.
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?