fix(unify): fixing icons and supporting router within the shared cypress commands package #18237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JessicaSachs
requested review from
flotwig and
chrisbreiding
and removed request for
a team
|
Thanks for taking the time to open a PR!
|
JessicaSachs
force-pushed
the
fix/icon-colors-and-shared-plugins
branch
from
1c015cf
to
231a2b2
Compare
…ess commands package
JessicaSachs
force-pushed
the
fix/icon-colors-and-shared-plugins
branch
from
231a2b2
to
3676263
Compare
JessicaSachs
commented
Sep 24, 2021
| Cypress.Commands.add( | ||
| 'mount', | ||
| <C extends Parameters<typeof mount>[0]>(comp: C, options: CyMountOptions<C> = {}) => { | ||
| export const registerMountFn = ({ plugins }) => { |
There was a problem hiding this comment.
CC @lmiller1990 🎉
…into the helper directory
…ss-io/cypress into fix/icon-colors-and-shared-plugins
elevatebart
approved these changes
Sep 24, 2021
Comment on lines
-84
to
+95
| * } | ||
| * } | ||
| */ | ||
| * { | ||
| * `.icon-light-green-500`: { | ||
| * '> *[stroke].icon-light': { | ||
| * stroke: resolvedColor | ||
| * }, | ||
| * '> *[fill].icon-light': { | ||
| * fill: resolvedColor | ||
| * } | ||
| * } | ||
| * } | ||
| */ |
There was a problem hiding this comment.
Yeah it was wrong the first time I wrote it.
tgriesser
added a commit
that referenced
this pull request
Sep 28, 2021
* unified-desktop-gui: (48 commits) refactor: remove nexus-decorators, add data context (#18211) fix mountFragment tests fix(unified-desktop-gui branch): initial installation on windows (#18247) fix(unify): fixing icons and supporting router within the shared cypress commands package (#18237) feat(launchpad): improve layout and design (#18238) feat(launchpad): add design tokens from Figma (#18223) fix(unify): appveyor windows issue + better icon types (#18226) fixing broken ct tests fix types remove old code chore: bump deps (#18213) feat(app): icon library supporting Cy's custom icons (#18195) feat(app): adding navigation, pages, router, and layout (#18194) chore: Update Chrome (stable) to 94.0.4606.54 (#18196) fix(launchpad): fix bugs introduced by urql/graphcache (#18193) chore: bump yarn.lock (#18204) feat: add gulp makePackage, begin to scaffold data-context (#18186) feat(launchpad): Directory Upload in Global Mode (#18165) chore(tests): fix flake in net stubbing/xhr/proxy logging tests (#18163) chore: remove nxs.gen.ts - should be created by codegen (#18184) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the component tests for the App aren't running and the icons don't look right within the tests. This PR fixes the local component tests for the App.
How to test
git checkout fix/icon-colors-and-shared-pluginscd packages/appyarn cypress:openand the component tests should render and look correct.Changes
frontend-shared/commands/command.tsto export a factory function where each project can inject the plugins it needs.CYPRESS_INTERNAL_CLOUD_ENVduring the remote schema stitching PR.