add "be.focused" and "have.focus" to assertions #3219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuceb
changed the title
brian-mann
requested changes
Jan 25, 2019
|
If this fixes the negated assertion bug from a long time ago that would be huge! |
|
The desktop-gui tests are legit failing though: https://circleci.com/gh/cypress-io/cypress/54253 |
|
got it, tests were doing |
|
Good. Let's not forget to revert cypress-io/cypress-documentation#1289 when this get merged. |
brian-mann
requested changes
Jan 27, 2019
🥇 great catch @dwelle |
3 tasks
brian-mann
previously requested changes
Jan 31, 2019
jennifer-shehane
requested review from
a team
and removed request for
brian-mann and
jennifer-shehane
brian-mann
approved these changes
May 1, 2019
brian-mann
added a commit
that referenced
this pull request
May 21, 2019
* add "be.focused" to chai_jquery * add comment explaining the mess * add type definitions * refactor assertion to use jquery assertion * remove trailing whitespace * add test for multiple elements, update typedefs * fix failing tests: not.be.visible -> not.exist * allow should(not.be.visible) for failed selectors * remove unrelated visibility changes * extract only focus assertion * Revert "Merge remote-tracking branch 'origin/develop' into issue-97-focus-assertion" This reverts commit b401c32, reversing changes made to ab14758. * force jquery to use custom focus pseudo selector * only force custom matchers for focus selectors * rewrote matchesSelector wrap code * add lodash * Merge in origin/develop * changes on 3.3.0 Co-authored-by: Brian Mann <brian.mann86@gmail.com>
This was referenced May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #97 add focus assertion
I wanted this to help me write some tests, so here it is
with this PR, the following are valid assertions:
fix for Implicit should 'exist' assertion is not being applied on cy.get() when other assertion. #205 assertion negation bugfix specs that use shouldnot.be.visibleinclude error message about changingnot.visibletonot.existnot.be.visibleto pass on non-existent selectors as beforedocs cypress-io/cypress-documentation#1362
remove docs that sayshould('not.have.element')will pass with no DOM node